[U-Boot] [PATCH v2 04/23] fs: fat: make directory iterator global for write use

Alexander Graf agraf at suse.de
Tue Sep 4 10:57:54 UTC 2018



> Am 04.09.2018 um 12:50 schrieb Heinrich Schuchardt <xypron.glpk at gmx.de>:
> 
> 
> 
>> On 09/04/2018 11:01 AM, Alexander Graf wrote:
>> 
>> 
>>> On 04.09.18 09:49, AKASHI Takahiro wrote:
>>> Directory iterator was introduced in major re-work of read operation by
>>> Rob. We want to use it for write operation extensively as well.
>> 
>> Please indicate in the commit message that write operations are
>> implemented in a different .c file and so we have to export the
>> respective functions.
> 
> Why? Look at this ugly code:
> 
> fs/fat/fat_write.c:17:#include "fat.c"

In that case we don't need this patch at all, no?

Alex

> 
> Best regards
> 
> Heinrich
> 
>> 
>> Alex
>> 


More information about the U-Boot mailing list