[U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

[Mario Six]

Hi Jagan, Heiko,

On Tue, Sep 4, 2018 at 8:10 AM Jagan Teki <jagan at amarulasolutions.com> wrote:
>
> Hi Mario/Kim/Heiko,
>
> On Tue, Aug 21, 2018 at 8:42 PM, Christophe LEROY
> <christophe.leroy at c-s.fr> wrote:
> > Hi Mario,
> >
> >
> > Le 10/08/2018 à 09:57, Mario Six a écrit :
> >>
> >> Hi Christophe,
> >>
> >> On Fri, Aug 10, 2018 at 9:35 AM Christophe LEROY
> >> <christophe.leroy at c-s.fr> wrote:
> >>>
> >>>
> >>> Hello Mario,
> >>>
> >>> Le 26/04/2018 à 10:36, Mario Six a écrit :
> >>>>
> >>>> Hi Joakim,
> >>>>
> >>>> On Thu, Apr 26, 2018 at 10:23 AM, Joakim Tjernlund
> >>>> <Joakim.Tjernlund at infinera.com> wrote:
> >>>>>
> >>>>> On Thu, 2018-04-26 at 11:35 +0530, Jagan Teki wrote:
> >>>>>>
> >>>>>> On Thu, Apr 26, 2018 at 11:24 AM, Mario Six <mario.six at gdsys.cc>
> >>>>>> wrote:
> >>>>>>>
> >>>>>>> Hi Jagan,
> >>>>>>>
> >>>>>>> On Thu, Apr 26, 2018 at 7:30 AM, Jagan Teki
> >>>>>>> <jagannadh.teki at gmail.com> wrote:
> >>>>>>>>
> >>>>>>>> On Thu, Apr 19, 2018 at 6:06 PM, Mario Six <mario.six at gdsys.cc>
> >>>>>>>> wrote:
> >>>>>>>>>
> >>>>>>>>> This is v2 of a patch series that adds support for DM to the
> >>>>>>>>> MPC8XXX SPI
> >>>>>>>>> driver, cleans up the driver code, fixes a few minor problems.
> >>>>>>>>>
> >>>>>>>>> Some TODOs are left over for later, such as proper SPI speed
> >>>>>>>>> setting,
> >>>>>>>>> and support for SPI mode setting. These would be enhancements to
> >>>>>>>>> the
> >>>>>>>>> original functionality, and can come later.
> >>>>>>>>>
> >>>>>>>>> The legacy functionality is removed in this version, so old boards
> >>>>>>>>> in
> >>>>>>>>> the tree might end up with broken SPI functionality.
> >>>>>>>>>
> >>>>>>>>> Mario Six (18):
> >>>>>>>>>     spi: mpc8xxx: Use short type names
> >>>>>>>>>     spi: mpc8xxx: Fix comments
> >>>>>>>>>     spi: mpc8xxx: Rename camel-case variables
> >>>>>>>>>     spi: mpc8xxx: Fix space after cast
> >>>>>>>>>     spi: mpc8xxx: Fix function names in strings
> >>>>>>>>>     spi: mpc8xxx: Replace defines with enums
> >>>>>>>>>     spi: mpc8xxx: Use IO accessors
> >>>>>>>>>     spi: mpc8xxx: Simplify if
> >>>>>>>>>     spi: mpc8xxx: Get rid of is_read
> >>>>>>>>>     spi: mpc8xxx: Simplify logic a bit
> >>>>>>>>>     spi: mpc8xxx: Reduce scope of loop variables
> >>>>>>>>>     spi: mpc8xxx: Make code more readable
> >>>>>>>>>     spi: mpc8xxx: Rename variable
> >>>>>>>>>     spi: mpc8xxx: Document LEN setting better
> >>>>>>>>>     spi: mpc8xxx: Re-order transfer setup
> >>>>>>>>>     spi: mpc8xxx: Fix if check
> >>>>>>>>>     spi: mpc8xxx: Use get_timer
> >>>>>>>>>     spi: mpc8xxx: Convert to DM
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> Boards with
> >>>>>>>> - configs/MPC8349EMDS_defconfig
> >>>>>>>> - configs/ids8313_defconfig
>
> Can you convert this boards to use DM_SPI, we have build issue[2]
>

Heiko, if you agree, I'd say we disable the SPI support for this board for now
(and possibly permanently), since really supporting the SPI multiplexer would
entail writing a DM driver for it, which would entail creating a SPI mux
uclass, and similar inconveniences (and I think putting that much work in a
board that old is at least dubious). As far as I can tell, this is the only
board with the multiplexer mechanism.

I have two more larger conversion series in my queue, which will hopefully make
it easier to convert the MPC83xx boards to DM (including SPI), but since I'm
busy working on non-U-Boot-related things right now, I won't be able to
finalize the first this week; hopefully next week.

>
> [2] https://travis-ci.org/openedev/u-boot-amarula/jobs/412956049
>

Best regards,
Mario