[U-Boot] [PATCH 2/3] mmc: omap_mmc: Remove invert references with gpio xlate available

[Jean-Jacques Hiblot]

Adam,


On 05/09/2018 11:35, Adam Ford wrote:
> With omap_gpio now translating GPIO_ACTIVE_LOW, any boards
> using the 'invert' option will no longer need to do this.  This
> patch removes the support for 'invert' from the MMC driver.
>
> Signed-off-by: Adam Ford <aford173 at gmail.com>
>
> diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c
> index 8ab56d247d..e9786ec5bb 100644
> --- a/drivers/mmc/omap_hsmmc.c
> +++ b/drivers/mmc/omap_hsmmc.c
> @@ -83,7 +83,6 @@ struct omap_hsmmc_data {
>   #if CONFIG_IS_ENABLED(DM_MMC)
>   	struct gpio_desc cd_gpio;	/* Change Detect GPIO */
>   	struct gpio_desc wp_gpio;	/* Write Protect GPIO */
> -	bool cd_inverted;

>   #else
>   	int cd_gpio;
>   	int wp_gpio;
> @@ -1377,8 +1376,6 @@ static int omap_hsmmc_getcd(struct udevice *dev)
>   	if (value < 0)
>   		return 1;
>   
> -	if (priv->cd_inverted)
> -		return !value;
>   	return value;
>   }
>   
> @@ -1860,10 +1857,6 @@ static int omap_hsmmc_ofdata_to_platdata(struct udevice *dev)
>   	}
>   #endif
>   
> -#ifdef OMAP_HSMMC_USE_GPIO
> -	plat->cd_inverted = fdtdec_get_bool(fdt, node, "cd-inverted");
> -#endif
> -
>   	return 0;
>   }
>   #endif
> @@ -1892,9 +1885,6 @@ static int omap_hsmmc_probe(struct udevice *dev)
>   	priv->base_addr = plat->base_addr;
>   	priv->controller_flags = plat->controller_flags;
>   	priv->hw_rev = plat->hw_rev;
> -#ifdef OMAP_HSMMC_USE_GPIO
> -	priv->cd_inverted = plat->cd_inverted;
Could you remove it also from struct omap_hsmmc_plat since it is not 
used anymore ?

JJ
> -#endif
>   
>   #ifdef CONFIG_BLK
>   	mmc = plat->mmc;