[U-Boot] [PATCH v2] gpio: dwapb_gpio: Change to use devm_kcalloc()

Ley Foon Tan ley.foon.tan at intel.com
Fri Sep 7 06:24:38 UTC 2018


Change to use managed resource function devm_kcalloc(),
so it will auto free memory when driver is removed.

Signed-off-by: Ley Foon Tan <ley.foon.tan at intel.com>

---
v2:
- Remove free() function.
---
 drivers/gpio/dwapb_gpio.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/dwapb_gpio.c b/drivers/gpio/dwapb_gpio.c
index 0f6574d..6f9d17d 100644
--- a/drivers/gpio/dwapb_gpio.c
+++ b/drivers/gpio/dwapb_gpio.c
@@ -171,8 +171,7 @@ static int gpio_dwapb_bind(struct udevice *dev)
 		if (!fdtdec_get_bool(blob, node, "gpio-controller"))
 			continue;
 
-		plat = NULL;
-		plat = calloc(1, sizeof(*plat));
+		plat = devm_kcalloc(dev, 1, sizeof(*plat), GFP_KERNEL);
 		if (!plat)
 			return -ENOMEM;
 
@@ -196,7 +195,6 @@ static int gpio_dwapb_bind(struct udevice *dev)
 	return 0;
 
 err:
-	free(plat);
 	return ret;
 }
 
-- 
2.2.2



More information about the U-Boot mailing list