[U-Boot] [PATCH v3 01/26] fs: fat: guard the content of include/fat.h

Alexander Graf agraf at suse.de
Wed Sep 12 05:41:05 UTC 2018



On 12.09.18 02:53, Akashi, Takahiro wrote:
> On Tue, Sep 11, 2018 at 12:12:53PM +0200, Alexander Graf wrote:
>>
>>
>> On 11.09.18 08:58, Akashi, Takahiro wrote:
>>> From: AKASHI Takahiro <takahiro.akashi at linaro.org>
>>>
>>> The whole content of include/fat.h is private to FAT implementation
>>> and then should be guarded with CONFIG_FS_FAT.
>>>
>>> Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
>>
>> I thought we could drop this patch now?
> 
> No, we can't as I said in
> https://lists.denx.de/pipermail/u-boot/2018-September/340233.html
> 
>> If you really need it, please state why in the patch description and
> 
> Oops, I've forgot to do so.
> 
>> make sure to include common.h before you do the #ifdef on CONFIG_FS_FAT.
>> Otherwise the symbol might not be declared.
> 
> Forgot it, too :)
> 
> Can I re-submit only this patch(01/26) rather than my whole patch set?

Sure. All other patches are applied.


Alex


More information about the U-Boot mailing list