[U-Boot] [PATCH v3 0/5] Add get_alt_function ops

Patrice CHOTARD patrice.chotard at st.com
Wed Sep 12 07:09:25 UTC 2018


Hi Stephen

On 09/11/2018 07:03 PM, Stephen Warren wrote:
> On 09/11/2018 01:31 AM, Patrice CHOTARD wrote:
>> Hi Michal
>>
>> On 09/11/2018 07:51 AM, Michal Simek wrote:
>>> On 10.9.2018 18:11, Patrice Chotard wrote:
>>>>
>>>> This series :
>>>>    - Add new gpio ops get_alt_function
>>>>    - Add get_function and get_alt_function support to stm32 gpio driver
>>>>    - Add get_alt_function test
>>>
>>>
>>> I went quickly over this series and TBH I am not getting what this is
>>> for. It looks like that this is the part of pinmux.
>>>
>>> Can you please elaborate more what this is for?
>>
>> Currently, get_function callback returns the state of a gpio
>> (GPIOF_INPUT, GPIOF_OUTPUT or GPIO_FUNC).
>>
>> If a pin's state is GPIO_FUNC, it's useful to know which alternate
>> function is selected for debug purpose.
> 
> This sounds like pinmux not GPIO. There should be a pinmux printing
> command to dump the pinmux state; the GPIO command shouldn't know about it.

Ok i will abandon this series and submit a new one implementing a new
pinmux command.

Thanks

Patrice


More information about the U-Boot mailing list