[U-Boot] [PATCH v3 12/14] pico-imx6ul: Remove CONFIG_FSL_USDHC from .h

Otavio Salvador otavio.salvador at ossystems.com.br
Thu Sep 13 22:01:36 UTC 2018


On Thu, Sep 13, 2018 at 6:49 PM Fabio Estevam <festevam at gmail.com> wrote:
>
> On Thu, Sep 13, 2018 at 6:33 PM, Otavio Salvador
> <otavio.salvador at ossystems.com.br> wrote:
> > On Thu, Sep 13, 2018 at 5:14 PM Fabio Estevam <festevam at gmail.com> wrote:
> >>
> > ...
> >> I see that CONFIG_FSL_USDHC is defined inside "mx6_common.h", which is
> >> already included in this file, so the change looks good, but the
> >> commit message needs to be reworked.
> >
> > Like:
> >
> > pico-imx6ul: Remove CONFIG_FSL_USDHC from .h
> >
> > The CONFIG_FSL_USDHC is defined inside "mx6_common.h", which is
> > already included in this file.
> >
> > Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>
> Yes, this looks good.
>
> You can also add:
>
> Reviewed-by: Fabio Estevam <festevam at gmail.com>

I will wait until tomorrow to send v4.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750


More information about the U-Boot mailing list