[U-Boot] [PATCH v3 13/14] pico-imx6ul: Add Falcon mode support

Stefano Babic sbabic at denx.de
Fri Sep 14 13:23:46 UTC 2018


On 14/09/2018 15:19, Otavio Salvador wrote:
> On Fri, Sep 14, 2018 at 10:07 AM Stefano Babic <sbabic at denx.de> wrote:
>> On 14/09/2018 14:49, Otavio Salvador wrote:
>>> On Fri, Sep 14, 2018 at 8:53 AM Stefano Babic <sbabic at denx.de> wrote:
>>>> On 13/09/2018 21:57, Otavio Salvador wrote:
>>>>> Falcon mode boots the kernel directly from SPL, without loading
>>>>> the full U-Boot.
>>>>>
>>>>> As pico-imx6ul does not have a GPIO for selecting Falcon versus normal
>>>>> mode, enter in Falcon mode when the customer selects the
>>>>> CONFIG_SPL_OS_BOOT option in menuconfig.
>>>>>
>>>>
>>>> I merged two days ago V2 on my branch with just minor conflicts in
>>>> ico-imx6ul.h on current tree. New version looks identical to V2 with
>>>> exception of the last two patches. Is it enough I pick up the last two
>>>> patches or is there something I am missing ?
>>>
>>> Some commit log improvements. As it wasn't push to imx tree,
>>
>> Due to breakage before release, I was convinced by Tom to run a full
>> travis before any PR (I push my local branch to github to let travis
>> build it: https://github.com/sbabic/u-boot-imx)
>>
>> Yes, that the reason my question: I am still able to change before merging.
>>
>>> do you
>>> want me to send v4 with all fixes?
>>
>> As far as I see, it is not required. I fixed myself the niptick in
>> commit log for 1/14, and I have already rebase and fix the conflicts in
>> pico-imx6ul - there is no need to redo the same work.
>>
>> I cannot find any other changes between V2 and V3, so I am getting  to
>> pick up the last two commits before pushing to the server.
> 
> Great.
> 
> Please amend:
> 
> Author: Otavio Salvador <otavio at ossystems.com.br>
> Date:   Thu Aug 30 13:48:47 2018 -0300
> 
>     pico-imx6ul: Remove CONFIG_FSL_USDHC from .h
> 
>     The CONFIG_FSL_USDHC is defined inside "mx6_common.h", which is
>     already included in this file.
> 
>     Reviewed-by: Fabio Estevam <festevam at gmail.com>
>     Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
> 

ok, thanks, done.

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list