[U-Boot] [PATCH 2/6] tegra20: common: fix USB_EHCI_TXFIFO_THRESH value

Marcel Ziswiler marcel.ziswiler at toradex.com
Mon Sep 17 10:10:44 UTC 2018


On Sun, 2018-09-16 at 18:22 +0100, Peter Robinson wrote:
> All other Tegra devices that define USB_EHCI_TXFIFO_THRESH use hex
> representation, fix tegra20 to be the same format.
> 
> Signed-off-by: Peter Robinson <pbrobinson at gmail.com>
> Cc: Tom Warren <twarren at nvidia.com>
> Cc: Stephen Warren <swarren at nvidia.com>
> ---
>  include/configs/tegra20-common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/tegra20-common.h
> b/include/configs/tegra20-common.h
> index 7f0a5292c2e..3551616cd1e 100644
> --- a/include/configs/tegra20-common.h
> +++ b/include/configs/tegra20-common.h
> @@ -78,7 +78,7 @@
>   * parameter, the default (2) causes occasional Data Buffer Errors
> in OUT
>   * packets depending on the buffer address and size.
>   */
> -#define CONFIG_USB_EHCI_TXFIFO_THRESH	10
> +#define CONFIG_USB_EHCI_TXFIFO_THRESH	0x10

I'm not quite sure about this one but believe that 10 on tegra20 vs.
0x10 on the others may actually be intentional. At least the same value
is used in the Linux kernel:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree
/drivers/usb/host/ehci-tegra.c#n567

Maybe one of them Warrens would know where exactly that
distinction/value came from?

However, I agree that using 0xa instead of 10 would make this more
clear.

>  #define CONFIG_EHCI_IS_TDI
>  
>  #define CONFIG_SYS_NAND_SELF_INIT


More information about the U-Boot mailing list