[U-Boot] [PATCH v2 13/13] configs: sandbox*: Enable UBSAN

Eugeniu Rosca roscaeugeniu at gmail.com
Mon Sep 17 21:10:06 UTC 2018


Hi Simon,

On Wed, Aug 29, 2018 at 08:51:24PM -0600, Simon Glass wrote:
> Hi,
> 
> On 26 August 2018 at 17:13, Eugeniu Rosca <roscaeugeniu at gmail.com> wrote:
> > On Sun, Aug 19, 2018 at 09:51:32PM -0400, Tom Rini wrote:
> >> [..] we should be able to say more broadly that just about everyone
> >> can enable this, but only out of the box sandbox should.
> >
> > Hence, turn UBSAN on for every available sandbox flavor.
> > Make sure the inserted line complies with `make savedefconfig`.
> >
> > The size increase of sandbox_defconfig U-Boot (gcc 8.1.0):
> > $ size u-boot.sandbox.*
> >     text    data     bss     dec     hex filename
> >  1234958   80048  291472 1606478  18834e u-boot.sandbox.default
> >  1422710  272240  291472 1986422  1e4f76 u-boot.sandbox.ubsan
> >  +187752 +192192       0 +379944
> >
> > Signed-off-by: Eugeniu Rosca <erosca at de.adit-jv.com>
> > ---
> >
> > Changes in v2:
> >  - None. Newly pushed.
> > ---
> >  configs/sandbox64_defconfig        | 1 +
> >  configs/sandbox_defconfig          | 1 +
> >  configs/sandbox_flattree_defconfig | 1 +
> >  configs/sandbox_noblk_defconfig    | 1 +
> >  configs/sandbox_spl_defconfig      | 1 +
> >  5 files changed, 5 insertions(+)
> >
> 
> Can you please do this with an 'imply' in arch/Kconfig?

Thanks for your review comment. I will incorporate the change in the
next patch revision, once we clarify how to deal with the "left-shifting
of 1 into the sign bit" UBSAN warnings, which is being discussed in
https://patchwork.ozlabs.org/patch/962305/#1991283 .

> Regards,
> Simon

Regards,
Eugeniu.


More information about the U-Boot mailing list