[U-Boot] [PATCH] misc: Add support for the Arm Versatile Express config bus

Heiko Schocher hs at denx.de
Tue Sep 18 04:18:48 UTC 2018


Hello Liviu,

Am 17.09.2018 um 18:48 schrieb Liviu Dudau:
> Add support for the Arm Versatile Express config bus that is
> being used for exposing various subsystems via a generic
> configuration bus. This driver adds support for generating
> transactions on this configuration bus and can be used by
> other drivers to abstract the communication with the actual
> function providers.
> 
> Signed-off-by: Liviu Dudau <liviu.dudau at foss.arm.com>
> ---
>   drivers/misc/Kconfig           |   8 +++
>   drivers/misc/Makefile          |   1 +
>   drivers/misc/vexpress_config.c | 127 +++++++++++++++++++++++++++++++++
>   3 files changed, 136 insertions(+)
>   create mode 100644 drivers/misc/vexpress_config.c
> 

Beside of a nitpick

Reviewed-by: Heiko Schocher <hs at denx.de>

[...]
> diff --git a/drivers/misc/vexpress_config.c b/drivers/misc/vexpress_config.c
> new file mode 100644
> index 0000000000..2cd433d01e
> --- /dev/null
> +++ b/drivers/misc/vexpress_config.c
> @@ -0,1 +1,127 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2018 Arm Ltd
> + * Author: Liviu Dudau <liviu.dudau at foss.arm.com>
> + *
> + */
> +#define DEBUG

Really enable debug?

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de


More information about the U-Boot mailing list