[U-Boot] [PATCH 1/3] configs: migrate CONFIG_PHY_AQUANTIA to Kconfig

[York Sun]

On 09/18/2018 03:22 PM, Jeremy Gebben wrote:
> On Tue, Sep 18, 2018 at 4:07 PM York Sun <york.sun at nxp.com> wrote:
>>
>> On 09/18/2018 02:50 PM, Jeremy Gebben wrote:
>>> The aquantia driver requires both CONFIG_PHY_GIGE and CONFIG_PHYLIB_10G.
>>>
>>> Signed-off-by: Jeremy Gebben <jgebben at sweptlaser.com>
>>> ---
>>>  configs/T1023RDB_NAND_defconfig                      | 2 +-
>>>  configs/T1023RDB_SDCARD_defconfig                    | 2 +-
>>>  configs/T1023RDB_SECURE_BOOT_defconfig               | 2 +-
>>>  configs/T1023RDB_SPIFLASH_defconfig                  | 2 +-
>>>  configs/T1023RDB_defconfig                           | 2 +-
>>>  configs/T1024RDB_NAND_defconfig                      | 2 +-
>>>  configs/T1024RDB_SDCARD_defconfig                    | 2 +-
>>>  configs/T1024RDB_SECURE_BOOT_defconfig               | 2 +-
>>>  configs/T1024RDB_SPIFLASH_defconfig                  | 2 +-
>>>  configs/T1024RDB_defconfig                           | 2 +-
>>>  configs/T2080QDS_NAND_defconfig                      | 2 +-
>>>  configs/T2080QDS_SDCARD_defconfig                    | 2 +-
>>>  configs/T2080QDS_SECURE_BOOT_defconfig               | 2 +-
>>>  configs/T2080QDS_SPIFLASH_defconfig                  | 2 +-
>>>  configs/T2080QDS_SRIO_PCIE_BOOT_defconfig            | 2 +-
>>>  configs/T2080QDS_defconfig                           | 2 +-
>>>  configs/T2080RDB_NAND_defconfig                      | 2 +-
>>>  configs/T2080RDB_SDCARD_defconfig                    | 2 +-
>>>  configs/T2080RDB_SECURE_BOOT_defconfig               | 2 +-
>>>  configs/T2080RDB_SPIFLASH_defconfig                  | 2 +-
>>>  configs/T2080RDB_SRIO_PCIE_BOOT_defconfig            | 2 +-
>>>  configs/T2080RDB_defconfig                           | 2 +-
>>>  configs/T2081QDS_NAND_defconfig                      | 2 +-
>>>  configs/T2081QDS_SDCARD_defconfig                    | 2 +-
>>>  configs/T2081QDS_SPIFLASH_defconfig                  | 2 +-
>>>  configs/T2081QDS_SRIO_PCIE_BOOT_defconfig            | 2 +-
>>>  configs/T2081QDS_defconfig                           | 2 +-
>>>  configs/ls1043ardb_defconfig                         | 2 +-
>>>  configs/ls1043ardb_nand_SECURE_BOOT_defconfig        | 2 +-
>>>  configs/ls1043ardb_nand_defconfig                    | 2 +-
>>>  configs/ls1043ardb_sdcard_defconfig                  | 2 +-
>>>  configs/ls1046ardb_emmc_defconfig                    | 2 +-
>>>  configs/ls1046ardb_qspi_SECURE_BOOT_defconfig        | 2 +-
>>>  configs/ls1046ardb_qspi_defconfig                    | 2 +-
>>>  configs/ls1046ardb_sdcard_SECURE_BOOT_defconfig      | 2 +-
>>>  configs/ls1046ardb_sdcard_defconfig                  | 2 +-
>>>  configs/ls1088ardb_qspi_SECURE_BOOT_defconfig        | 1 +
>>>  configs/ls1088ardb_qspi_defconfig                    | 1 +
>>>  configs/ls1088ardb_sdcard_qspi_SECURE_BOOT_defconfig | 1 +
>>>  configs/ls1088ardb_sdcard_qspi_defconfig             | 1 +
>>>  configs/ls2080ardb_defconfig                         | 2 +-
>>>  configs/ls2080ardb_nand_defconfig                    | 2 +-
>>>  drivers/net/phy/Kconfig                              | 2 ++
>>>  drivers/net/phy/aquantia.c                           | 4 ----
>>>  include/configs/T102xRDB.h                           | 2 --
>>>  include/configs/T208xRDB.h                           | 2 --
>>>  include/configs/ls1043ardb.h                         | 2 --
>>>  include/configs/ls1046ardb.h                         | 2 --
>>>  include/configs/ls1088ardb.h                         | 3 ---
>>>  include/configs/ls2080ardb.h                         | 3 ---
>>>  50 files changed, 44 insertions(+), 56 deletions(-)
>>>
>>> diff --git a/configs/T1023RDB_NAND_defconfig b/configs/T1023RDB_NAND_defconfig
>>> index dc3dcb9989..03016158fc 100644
>>> --- a/configs/T1023RDB_NAND_defconfig
>>> +++ b/configs/T1023RDB_NAND_defconfig
>>> @@ -48,7 +48,7 @@ CONFIG_NAND=y
>>>  CONFIG_SPI_FLASH=y
>>>  CONFIG_SPI_FLASH_SPANSION=y
>>>  CONFIG_PHYLIB=y
>>> -CONFIG_PHY_GIGE=y
>>> +CONFIG_PHY_AQUANTIA=y
>>>  CONFIG_E1000=y
>>>  CONFIG_MII=y
>>>  CONFIG_SYS_NS16550=y
>>
>> Shouldn't this patch be put after your 2nd patch?
> 
> If you prefer, but it should work either way.  CONFIG_PHY_AQUANTIA
> already existed in Kconfig, but it was being set in header files
> instead of defconfigs.
> 

I didn't realize PHY_AQUANTIA already exists in Kconfig. PHY_GIGE is
selected so it doesn't need to be set in defconfig. Your patch is OK.

York