[U-Boot] [PATCH 1/1] test/py: catch errors occurring when reading the console

Stephen Warren swarren at wwwdotorg.org
Thu Sep 20 19:07:52 UTC 2018


On 09/20/2018 12:19 PM, Heinrich Schuchardt wrote:
> Spawn.exept has a try block without 'except'.
> 
> When the py test is running it is connected via pipes to the U-Boot
> process. If the U-Boot process ends prematurely, e.g. due to a
> segmentation fault, the pipes are broken. Trying to read from a broken
> pipe results in an OSError. Catch the exception and treat the broken pipe
> like any other end of output. By returning None expect() indicates that
> the output does not match.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> ---
> I suggest that Alex takes the patch because we need it when working on
> the efi-next branch.
> 
> v3
> 	add more comments

Adding comments doesn't solve the fundamental problem with this patch. 
I'll send an alternative patch in a minute. That patch will hide 
exceptions only during a very specific portion of time, rather than just 
ignoring all of them.


More information about the U-Boot mailing list