[U-Boot] [PATCH v4 12/17] board_f: Use static print_cpuinfo if CONFIG_CPU is active
Mario Six
mario.six at gdsys.cc
Fri Sep 21 06:56:01 UTC 2018
Hi Simon,
On Wed, Sep 19, 2018 at 5:30 PM Simon Glass <sjg at chromium.org> wrote:
>
> Hi Mario,
>
> On 6 August 2018 at 02:23, Mario Six <mario.six at gdsys.cc> wrote:
> > When the DM CPU drivers are active, printing information about a CPU
> > should be delegated to a matching driver.
> >
> > Hence, add a static print_cpuinfo that implements this delegation when
> > DM CPU drivers are active.
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> > Signed-off-by: Mario Six <mario.six at gdsys.cc>
> > ---
> >
> > Notes:
> > v3 -> v4:
> > * Print error if CPU description could not be retrieved
> > * Improved error handling and debug reporting
> > * Added documentation
> >
> > v2 -> v3:
> > No changes
> >
> > v1 -> v2:
> > New in v2
> >
> > common/board_f.c | 28 ++++++++++++++++++++++++++++
> > include/init.h | 7 +++++++
> > 2 files changed, 35 insertions(+)
> >
>
> I have applied this, but with a change to use CONFIG_IS_ENABLED(CPU).
>
> At present chromebook_link64 calls print_cpuinfo() from SPL, so we
> need something like this.
>
> Perhaps a better fix is to move the function into common/init ?
>
Yeah, sounds reasonable. I'll look into it.
> Regards,
> Simon
>
Best regards,
Mario
More information about the U-Boot
mailing list