[U-Boot] [PATCH v3 05/20] mmc: rpmb: add mmc_rpmb_route_frames()

Jens Wiklander jens.wiklander at linaro.org
Tue Sep 25 06:14:10 UTC 2018


Hi Simon,

On Fri, Sep 14, 2018 at 12:53 PM, Simon Glass <sjg at chromium.org> wrote:
> Hi Jens,
>
> On 3 September 2018 at 16:46, Jens Wiklander <jens.wiklander at linaro.org> wrote:
>> Adds mmc_rpmb_route_frames() to route RPMB data frames from/to an
>> external entity.
>>
>> Tested-by: Igor Opaniuk <igor.opaniuk at linaro.org>
>> Signed-off-by: Jens Wiklander <jens.wiklander at linaro.org>
>> ---
>>  drivers/mmc/rpmb.c | 160 +++++++++++++++++++++++++++++++++++++++++++++
>>  include/mmc.h      |   2 +
>>  2 files changed, 162 insertions(+)
>>
>
> [..]
>
>> diff --git a/include/mmc.h b/include/mmc.h
>> index df4255b828a7..d6e02af4edea 100644
>> --- a/include/mmc.h
>> +++ b/include/mmc.h
>> @@ -748,6 +748,8 @@ int mmc_rpmb_read(struct mmc *mmc, void *addr, unsigned short blk,
>>                   unsigned short cnt, unsigned char *key);
>>  int mmc_rpmb_write(struct mmc *mmc, void *addr, unsigned short blk,
>>                    unsigned short cnt, unsigned char *key);
>> +int mmc_rpmb_route_frames(struct mmc *mmc, void *req, unsigned long reqlen,
>> +                         void *rsp, unsigned long rsplen);
>
> Please can you add a full comment to this function? All header-file
> functions should be commented.

I'll fix.

Thanks,
Jens


More information about the U-Boot mailing list