[U-Boot] [PATCH 5/6] test: Add PCI device entry without compat string and with DT node

[Bin Meng]

Hi Marek,

On Sat, Sep 22, 2018 at 7:02 AM Marek Vasut <marek.vasut at gmail.com> wrote:
>
> Add PCI entry without compatible string and with a DT node only with
> reg = <...> property into the DT. This is needed for the tests to
> verify whether such a setup creates an U-Boot PCI device with the
> DT node associated with it in udevice.node.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas at gmail.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Tom Rini <trini at konsulko.com>
> ---
>  arch/sandbox/dts/test.dts | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
> index b8524e3b7d..c13a270c2e 100644
> --- a/arch/sandbox/dts/test.dts
> +++ b/arch/sandbox/dts/test.dts
> @@ -354,9 +354,14 @@
>                 #address-cells = <3>;
>                 #size-cells = <2>;
>                 ranges = <0x02000000 0 0x30000000 0x30000000 0 0x2000
> -                               0x01000000 0 0x40000000 0x40000000 0 0x2000>;
> +                         0x01000000 0 0x40000000 0x40000000 0 0x2000
> +                         0x00008000 0 0x00000000 0x00008000 0 0x2000>;

Adding this line makes no sense. You can't translate a PCI bus
configuration space address (0x8000) to something in its parent bus's
(MMIO) address space. See my related comments in patch 1 and 3.

>                 sandbox,dev-info = <0x08 0x00 0x1234 0x5678
> -                                   0x0c 0x00 0x1234 0x5678>;
> +                                   0x0c 0x00 0x1234 0x5678
> +                                   0x10 0x00 0x1234 0x5678>;
> +               pci at 10,0 {
> +                       reg = <0x8000 0 0 0 0>;
> +               };
>         };
>
>         pci2: pci-controller2 {
> --

Regards,
Bin