[U-Boot] [PATCH v3 6/8] powerpc: mpc85xx: Use binman to embed dtb inside U-Boot

[York Sun]

On 09/26/2018 03:17 AM, Jagdish Gediya wrote:
> Hi York,
> 
>> -----Original Message-----
>> From: York Sun
>> Sent: Wednesday, September 26, 2018 12:19 AM
>> To: Jagdish Gediya <jagdish.gediya at nxp.com>; u-boot at lists.denx.de;
>> Prabhakar Kushwaha <prabhakar.kushwaha at nxp.com>; Poonam Aggrwal
>> <poonam.aggrwal at nxp.com>; sjg at chromium.org; bmeng.cn at gmail.com
>> Cc: trini at konsulko.com
>> Subject: Re: [PATCH v3 6/8] powerpc: mpc85xx: Use binman to embed dtb
>> inside U-Boot
>>
>> On 09/02/2018 10:08 PM, Jagdish Gediya wrote:
>>> Below is the sequence to embed dtb inside U-Boot, 1. Remove bootpg and
>>> resetvec section if needed 2. Append dtb 3. Append bootpg and resetvec
>>> section back if removed in step 1
>>>
>>> Above procedure is required only when CONFIG_MPC85xx and
>>> CONFIG_OF_SEPARATE are defined.
>>>
>>> Add new config CONFIG_MPC85XX_HAVE_RESET_VECTOR to indicate that
>> image
>>> has resetvec section. Step 1 and step 3 described above are required
>>> only if this config is y.
>>>
>>> Signed-off-by: Jagdish Gediya <jagdish.gediya at nxp.com>
>>> ---
>>> Changes for v2:
>>> 	- Don't change the generic target
>>> 	- Add new config option to use binman
>>>
>>> Changes for v3:
>>> 	- Commit message change('u-boot' -> 'U-Boot')
>>>
>>>  Makefile                         | 23 ++++++++++++++++++++++-
>>>  arch/powerpc/cpu/mpc85xx/Kconfig |  4 ++++
>>>  2 files changed, 26 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index b5bf8ab..03baa74 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -861,6 +861,10 @@ ifneq ($(CONFIG_SYS_INIT_SP_BSS_OFFSET),)
>>>  ALL-y += init_sp_bss_offset_check
>>>  endif
>>>
>>> +ifeq ($(CONFIG_MPC85xx)$(CONFIG_OF_SEPARATE),yy)
>>> +ALL-y += u-boot-with-dtb.bin
>>> +endif
>>> +
>>
>> One thing confuses me is the output file. My understand is we will use u-
>> boot-with-dtb.bin file. Other files are intermediate files. It would be helpful
>> to explain each output file, especially for debugging, and let other know we
>> switch from one file to another after this patch set.
> I have already updated the board README for u-boot-with-dtb.bin. Apart from it, Only one new (u-boot-br.bin) intermediate  file is generated with respect to the existing U-Boot compilations flow. Should I update board README or commit message for u-boot-br.bin?

I see the updated README for T2080QDS. I can see u-boot-br.bin from the
change history so it is clear to me. Maybe you can suggest additional
language to the commit message to make it more clear.

>>
>> CONFIG_OF_SEPARATE seems not be selected explicitly anywhere. Are we
>> relying on the first choice to be selected automatically? Is it guaranteed?
> yes, We are relying on the first choice to be selected automatically. It should be guaranteed, I am seeing that no configs in U-Boot are enabling it explicitly but many board uses u-boot-dtb.bin or files based on u-boot-dtb.bin for booting which are only generated if CONFIG_OF_SEPARATE is enabled.
> 

I didn't find anywhere saying the first choice is guaranteed if nothing
is explicitly selected.

York