[U-Boot] [PATCH] fs: fat: Fix warning in normalize_longname()

Tom Rini trini at konsulko.com
Sun Sep 30 14:33:42 UTC 2018


As observed with clang:
fs/fat/fat_write.c:1024:13: warning: comparison of constant 128
      with expression of type 'char' is always false
      [-Wtautological-constant-out-of-range-compare]
                if ((0x80 <= c) && (c <= 0xff))
                     ~~~~ ^  ~
fs/fat/fat_write.c:1024:25: warning: comparison of constant 255
      with expression of type 'char' is always true
      [-Wtautological-constant-out-of-range-compare]
                if ((0x80 <= c) && (c <= 0xff))
                                    ~ ^  ~~~~

Fixes: 25bb9dab14f4 ("fs: fat: check and normalize file name")
Cc: AKASHI Takahiro <takahiro.akashi at linaro.org>
Cc: Alexander Graf <agraf at suse.de>
Signed-off-by: Tom Rini <trini at konsulko.com>
---
 fs/fat/fat_write.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fat/fat_write.c b/fs/fat/fat_write.c
index fc211e74bc69..98fe6b2b4ecc 100644
--- a/fs/fat/fat_write.c
+++ b/fs/fat/fat_write.c
@@ -1005,7 +1005,7 @@ again:
 static int normalize_longname(char *l_filename, const char *filename)
 {
 	const char *p, legal[] = "!#$%&\'()-.@^`_{}~";
-	char c;
+	unsigned char c;
 	int name_len;
 
 	/* Check that the filename is valid */
-- 
2.7.4



More information about the U-Boot mailing list