[U-Boot] [PATCH 1/2] tools/imx8m_image.sh: remove bashism

Otavio Salvador otavio.salvador at ossystems.com.br
Mon Apr 1 13:20:34 UTC 2019


Hello everyone,

On Wed, Feb 27, 2019 at 10:44 PM Fabio Estevam <festevam at gmail.com> wrote:
> On Wed, Jan 2, 2019 at 4:59 AM Baruch Siach <baruch at tkos.co.il> wrote:
> > Use a single '=' to test string equality for compatibility with non-bash
> > shells. Otherwise, if /bin/sh is dash, build fails:
> >
> > ./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator
> > ./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator
> > ./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator
> > ./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator
> > WARNING './spl/u-boot-spl-ddr.bin' not found, resulting binary is not-functional
> >
> > Signed-off-by: Baruch Siach <baruch at tkos.co.il>
>
> I don't see this patch applied yet.
>
> Do we have other solution?

This is still broken and the proposed patch does fix it. We should get
this merged for 2019.04 release.

Please Stefano, consider this for release (be it through your branch
for directly by Tom).

Best Regards,

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750


More information about the U-Boot mailing list