[U-Boot] [PATCH] DTS: Fix ETH PHY reset on HSC|DDC boards (imx53)

[Lukasz Majewski]

Hi Fabio,

> Hi Lukasz,
> 
> On Mon, Apr 1, 2019 at 11:02 AM Lukasz Majewski <lukma at denx.de> wrote:
> >
> > After the commit: "eth: dm: fec: Add gpio phy reset binding"
> > SHA1: efd0b791069af93e9d439a70d1fe2ae8994dbbfa
> >
> > The FEC ETH driver switched to PHY GPIO reset performed with data
> > defined in DTS.
> > For the HSC|DDC boards the GPIO reset signal is active low and
> > hence the wrong DTS description must be changed (otherwise the
> > reset for ETH is not properly setup).  
> 
> We should probably use the same approach as in the kernel to avoid
> regressions with old dtbs.
> 
> In the kernel the GPIO polarity passed in the 'phy-reset-gpios'
> property is ignored and it is assumed to be active low, unless
> 'phy-reset-active-high' is passed.

This may be a good solution. 

However, I do hope that this fix will be accepted to v2019.04 as it is
necessary to have ETH working (and it is the only convenient way to
update u-boot on this board).

The other needed patch is to Revert "drivers/net/fec: phy_init: remove
redundant logic" as pointed out by Marcel.

> 
> Thanks

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190401/dffb119f/attachment.sig>