[U-Boot] [RFC 4/6] configs: exynos: Add new CONFIG_SYS_ODROID_USB config option

Krzysztof Kozlowski krzk at kernel.org
Tue Apr 2 07:02:19 UTC 2019


On Mon, 1 Apr 2019 at 19:17, Anand Moon <linux.amoon at gmail.com> wrote:
>
> Hi Krzysztof,
>
> On Mon, 1 Apr 2019 at 21:46, Krzysztof Kozlowski <krzk at kernel.org> wrote:
> >
> > On Mon, 1 Apr 2019 at 17:50, Anand Moon <linux.amoon at gmail.com> wrote:
> > >
> > > Hi Krzysztof,
> > >
> > > On Mon, 1 Apr 2019 at 18:27, Krzysztof Kozlowski <krzk at kernel.org> wrote:
> > > >
> > > > On Mon, 1 Apr 2019 at 13:53, Anand Moon <linux.amoon at gmail.com> wrote:
> > > > >
> > > > > Add new CONFIG_SYS_ODROID_USB flag to avoid compliation
> > > > > error on other development boards.
> > > > >
> > > > > Fix below compilation error:
> > > > > Error: You must add new CONFIG options using Kconfig
> > > > > The following new ad-hoc CONFIG options were detected:
> > > > > CONFIG_SYS_ODROID_USB
> > > >
> > > > There is no ad-hoc option "SYS_ODROID_USB" so it cannot cause build error.
> > > >
> > > > This is something wrong... Are you sure that you are compiling master branch?
> > > >
> > > > Best regards,
> > > > Krzysztof
> > > >
> > >
> > > [snip]
> > >
> > > CONFIG_SYS_ODROID_USB is adder to fix compilation error other development board.
> > > so this code is specific to the Odroid U3 and Odroid X2 boards.
> > >
> > > I have compiled both XU3 and U3 build with no problem.
> >
> > You quoted the error message saying that ad-hoc option
> > CONFIG_SYS_ODROID_USB was added. But such ad-hoc option does not
> > exist. Now you say that you add this to fix build problem... I really
> > do not understand. So let's simplify it - please tell me how I can
> > reproduce the problem and what is expected.
> >
> > Best regards,
> > Krzysztof
>
> This CONFIG_SYS_ODROID_USB options is more like and compile time flag
> defined in odroid.h and not on any other boards, so this flags add
> guard to the code.
>
> At the end of  u-boot compilation it would prompt that new config
> option is added
> please add this to some Kconfig so that it could be selected via make menuconfig
>
> See the link below, why I chose this options.
>
> [0] https://github.com/Xilinx/u-boot-xlnx/blob/master/doc/README.kconfig

Can you provide answer to this:
"So let's simplify it - please tell me how I can reproduce the problem
and what is expected."
?

Best regards,
Krzysztof


More information about the U-Boot mailing list