[U-Boot] [PATCH 07/13 v3] arm: at91: Enable watchdog support

Stefan Roese sr at denx.de
Tue Apr 2 11:50:13 UTC 2019


On 02.04.19 13:26, Eugen.Hristev at microchip.com wrote:
> 
> 
> On 02.04.2019 11:57, Stefan Roese wrote:
> 
>>
>> This patch enables and starts the watchdog on the AT91 platform if
>> configured. The WD timeout value is read in the AT91 WD device driver
>> from the DT, using the "timeout-sec" DT property. If not provided in
>> the DT, the default value of 2 seconds is used.
>>
>> Signed-off-by: Stefan Roese <sr at denx.de>
>> Cc: Heiko Schocher <hs at denx.de>
>> Cc: Andreas Bießmann <andreas at biessmann.org>
>> Cc: Eugen Hristev <eugen.hristev at microchip.com>
>> ---
>> v3:
>> - Move WDT struct and macros into arch header so that it can be used
>>     by the arch code to start the driver (timeout value)
>> - This change now enables the use of the "timeout-sec" DT property
>>     to specifiy a board specific WD timeout value
> 
> 
> Hi Stefan,
> 
> This breaks pm9261_defconfig
> 
>    AS      arch/arm/mach-at91/arm926ejs/lowlevel_init.o
> ./arch/arm/include/asm/arch/at91_wdt.h: Assembler messages:
> ./arch/arm/include/asm/arch/at91_wdt.h:50: Error: bad instruction
> `struct at91_wdt_priv {'
> ./arch/arm/include/asm/arch/at91_wdt.h:51: Error: bad instruction `void
> __iomem*regs'
> ./arch/arm/include/asm/arch/at91_wdt.h:52: Error: bad instruction `u32
> regval'
> ./arch/arm/include/asm/arch/at91_wdt.h:53: Error: bad instruction `u32
> timeout'
> ./arch/arm/include/asm/arch/at91_wdt.h:54: Error: junk at end of line,
> first unrecognized character is `}'
> scripts/Makefile.build:314: recipe for target
> 'arch/arm/mach-at91/arm926ejs/lowlevel_init.o' failed

Sorry about these breakages. I'll fix this and will run the new
patches through Travis and will only send the next version once
this is compile clean.

Thanks,
Stefan


More information about the U-Boot mailing list