[U-Boot] [PATCH v4 0/4] configs: rk3288: Tinker Board SPL file must fit into 32 KiB

[Tom Rini]

On Tue, Apr 02, 2019 at 07:33:42PM +0200, Heinrich Schuchardt wrote:
> On 4/2/19 7:29 PM, Tom Rini wrote:
> > On Tue, Apr 02, 2019 at 07:19:03PM +0200, Heinrich Schuchardt wrote:
> > 
> >> The SPL image for the Tinker Board has to fit into 32 KiB. This includes
> >> up to 2 KiB for the file header.
> >>
> >> A new configuration variable CONFIG_SPL_SIZE_LIMIT is introduced to define
> >> the board specific limit.
> >>
> >> A common Makefile function is used for this test and the test against
> >> CONFIG_BOARD_SIZE_LIMIT.
> >>
> >> Move the board size check from arch/arm/mach-imx/Makefile to Makefile.
> > 
> > I'm sorry you weren't Cc'd on Simon's thread where we're trying to
> > improve the size check stuff to be generic enough to use everywhere.  We
> > can't generically use a shell script as we need to know some processed
> > values too.  I don't know if Simon got to the point of writing a C based
> > helper to use or not.
> > 
> 
> Hello Tom,
> 
> could you, please, provide a link to the thread.

https://patchwork.ozlabs.org/patch/1050465/ (and no, I didn't apply it,
I forgot to delete my email before I sent out that batch of applieds).

> Is the test prior to my patch incorrect? Or do you want to imply that
> after my patch we get different results?

The problem is that I don't want to make wider use of the shell checking
notion.  It's not as complete as we'd like and can't be used on as many
platforms as need it either, due to needing cpp to actually determine
values in some cases.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190402/1a067864/attachment.sig>