[U-Boot] [PATCH 2/3] configs: Move CONFIG_CMD_USB_MASS_STORAGE properly into Kconfig

Jack Mitchell ml at embed.me.uk
Wed Apr 3 09:52:52 UTC 2019


Hi,

On 03/04/2019 10:34, Urja Rannikko wrote:
> This affects RK3036, RK322X and RK3288 - the defconfig changes done by
> moveconfig.py for the veyrons were left out on purpose because they dont
> have an OTG port, and will get their config updated in the next commit.
> 
> Signed-off-by: Urja Rannikko <urjaman at gmail.com>
> ---
>  configs/evb-rk3036_defconfig      | 2 +-
>  configs/evb-rk3229_defconfig      | 2 +-
>  configs/evb-rk3288_defconfig      | 2 +-
>  configs/fennec-rk3288_defconfig   | 2 +-
>  configs/firefly-rk3288_defconfig  | 2 +-
>  configs/kylin-rk3036_defconfig    | 2 +-
>  configs/miqi-rk3288_defconfig     | 2 +-
>  configs/phycore-rk3288_defconfig  | 2 +-
>  configs/popmetal-rk3288_defconfig | 2 +-
>  configs/rock2_defconfig           | 2 +-
>  configs/tinker-rk3288_defconfig   | 2 +-
>  include/configs/rk3036_common.h   | 1 -
>  include/configs/rk322x_common.h   | 1 -
>  include/configs/rk3288_common.h   | 1 -
>  include/configs/vyasa-rk3288.h    | 1 -
>  15 files changed, 11 insertions(+), 15 deletions(-)
> 
> diff --git a/configs/evb-rk3036_defconfig b/configs/evb-rk3036_defconfig
> index 8cc6abed17..89be51a495 100644
> --- a/configs/evb-rk3036_defconfig
> +++ b/configs/evb-rk3036_defconfig
> @@ -23,6 +23,7 @@ CONFIG_CMD_I2C=y
>  CONFIG_CMD_MMC=y
>  CONFIG_CMD_SF=y
>  CONFIG_CMD_SPI=y
> +CONFIG_CMD_USB_MASS_STORAGE=y
>  # CONFIG_CMD_SETEXPR is not set
>  CONFIG_CMD_CACHE=y
>  CONFIG_CMD_TIME=y
> @@ -55,7 +56,6 @@ CONFIG_USB_GADGET_MANUFACTURER="Rockchip"
>  CONFIG_USB_GADGET_VENDOR_NUM=0x2207
>  CONFIG_USB_GADGET_PRODUCT_NUM=0x310a
>  CONFIG_USB_GADGET_DWC2_OTG=y
> -CONFIG_USB_FUNCTION_MASS_STORAGE=y
>  CONFIG_SPL_TINY_MEMSET=y
>  CONFIG_CMD_DHRYSTONE=y
>  CONFIG_ERRNO_STR=y
> diff --git a/configs/evb-rk3229_defconfig b/configs/evb-rk3229_defconfig
> index 14ff54af20..80d7d179ae 100644
> --- a/configs/evb-rk3229_defconfig
> +++ b/configs/evb-rk3229_defconfig
> @@ -19,6 +19,7 @@ CONFIG_SPL_STACK_R=y
>  CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x200
>  CONFIG_CMD_GPT=y
>  CONFIG_CMD_MMC=y
> +CONFIG_CMD_USB_MASS_STORAGE=y
>  # CONFIG_CMD_SETEXPR is not set
>  CONFIG_CMD_TIME=y
>  CONFIG_SPL_OF_CONTROL=y
> @@ -55,5 +56,4 @@ CONFIG_USB_GADGET_MANUFACTURER="Rockchip"
>  CONFIG_USB_GADGET_VENDOR_NUM=0x2207
>  CONFIG_USB_GADGET_PRODUCT_NUM=0x320a
>  CONFIG_USB_GADGET_DWC2_OTG=y
> -CONFIG_USB_FUNCTION_MASS_STORAGE=y
>  CONFIG_ERRNO_STR=y
> diff --git a/configs/evb-rk3288_defconfig b/configs/evb-rk3288_defconfig
> index 8635fd9aaf..d6688d61c3 100644
> --- a/configs/evb-rk3288_defconfig
> +++ b/configs/evb-rk3288_defconfig
> @@ -24,6 +24,7 @@ CONFIG_CMD_MMC=y
>  CONFIG_CMD_SF=y
>  CONFIG_CMD_SPI=y
>  CONFIG_CMD_USB=y
> +CONFIG_CMD_USB_MASS_STORAGE=y
>  # CONFIG_CMD_SETEXPR is not set
>  CONFIG_CMD_CACHE=y
>  CONFIG_CMD_TIME=y
> @@ -76,7 +77,6 @@ CONFIG_USB_GADGET_MANUFACTURER="Rockchip"
>  CONFIG_USB_GADGET_VENDOR_NUM=0x2207
>  CONFIG_USB_GADGET_PRODUCT_NUM=0x320a
>  CONFIG_USB_GADGET_DWC2_OTG=y
> -CONFIG_USB_FUNCTION_MASS_STORAGE=y
>  CONFIG_DM_VIDEO=y
>  CONFIG_DISPLAY=y
>  CONFIG_VIDEO_ROCKCHIP=y
> diff --git a/configs/fennec-rk3288_defconfig b/configs/fennec-rk3288_defconfig
> index 668323fc2e..94996b6c02 100644
> --- a/configs/fennec-rk3288_defconfig
> +++ b/configs/fennec-rk3288_defconfig
> @@ -25,6 +25,7 @@ CONFIG_CMD_MMC=y
>  CONFIG_CMD_SF=y
>  CONFIG_CMD_SPI=y
>  CONFIG_CMD_USB=y
> +CONFIG_CMD_USB_MASS_STORAGE=y
>  # CONFIG_CMD_SETEXPR is not set
>  CONFIG_CMD_CACHE=y
>  CONFIG_CMD_TIME=y
> @@ -75,7 +76,6 @@ CONFIG_USB_GADGET_MANUFACTURER="Rockchip"
>  CONFIG_USB_GADGET_VENDOR_NUM=0x2207
>  CONFIG_USB_GADGET_PRODUCT_NUM=0x320a
>  CONFIG_USB_GADGET_DWC2_OTG=y
> -CONFIG_USB_FUNCTION_MASS_STORAGE=y
>  CONFIG_USB_HOST_ETHER=y
>  CONFIG_USB_ETHER_ASIX=y
>  CONFIG_USB_ETHER_SMSC95XX=y
> diff --git a/configs/firefly-rk3288_defconfig b/configs/firefly-rk3288_defconfig
> index ba5b3baf09..cc2cb268a3 100644
> --- a/configs/firefly-rk3288_defconfig
> +++ b/configs/firefly-rk3288_defconfig
> @@ -24,6 +24,7 @@ CONFIG_CMD_MMC=y
>  CONFIG_CMD_SF=y
>  CONFIG_CMD_SPI=y
>  CONFIG_CMD_USB=y
> +CONFIG_CMD_USB_MASS_STORAGE=y
>  # CONFIG_CMD_SETEXPR is not set
>  CONFIG_CMD_CACHE=y
>  CONFIG_CMD_TIME=y
> @@ -80,7 +81,6 @@ CONFIG_USB_GADGET_MANUFACTURER="Rockchip"
>  CONFIG_USB_GADGET_VENDOR_NUM=0x2207
>  CONFIG_USB_GADGET_PRODUCT_NUM=0x320a
>  CONFIG_USB_GADGET_DWC2_OTG=y
> -CONFIG_USB_FUNCTION_MASS_STORAGE=y
>  CONFIG_USB_HOST_ETHER=y
>  CONFIG_USB_ETHER_ASIX=y
>  CONFIG_USB_ETHER_SMSC95XX=y
> diff --git a/configs/kylin-rk3036_defconfig b/configs/kylin-rk3036_defconfig
> index 8abbc7c63e..f7a6991f94 100644
> --- a/configs/kylin-rk3036_defconfig
> +++ b/configs/kylin-rk3036_defconfig
> @@ -21,6 +21,7 @@ CONFIG_CMD_MMC=y
>  CONFIG_CMD_SF=y
>  CONFIG_CMD_SPI=y
>  CONFIG_CMD_USB=y
> +CONFIG_CMD_USB_MASS_STORAGE=y
>  # CONFIG_CMD_SETEXPR is not set
>  CONFIG_CMD_CACHE=y
>  CONFIG_CMD_TIME=y
> @@ -54,7 +55,6 @@ CONFIG_USB_GADGET_MANUFACTURER="Rockchip"
>  CONFIG_USB_GADGET_VENDOR_NUM=0x2207
>  CONFIG_USB_GADGET_PRODUCT_NUM=0x310a
>  CONFIG_USB_GADGET_DWC2_OTG=y
> -CONFIG_USB_FUNCTION_MASS_STORAGE=y
>  CONFIG_USB_HOST_ETHER=y
>  CONFIG_USB_ETHER_ASIX=y
>  CONFIG_USB_ETHER_SMSC95XX=y
> diff --git a/configs/miqi-rk3288_defconfig b/configs/miqi-rk3288_defconfig
> index abc46d0511..9b873cd978 100644
> --- a/configs/miqi-rk3288_defconfig
> +++ b/configs/miqi-rk3288_defconfig
> @@ -24,6 +24,7 @@ CONFIG_CMD_MMC=y
>  CONFIG_CMD_SF=y
>  CONFIG_CMD_SPI=y
>  CONFIG_CMD_USB=y
> +CONFIG_CMD_USB_MASS_STORAGE=y
>  # CONFIG_CMD_SETEXPR is not set
>  CONFIG_CMD_CACHE=y
>  CONFIG_CMD_TIME=y
> @@ -75,7 +76,6 @@ CONFIG_USB_GADGET_MANUFACTURER="Rockchip"
>  CONFIG_USB_GADGET_VENDOR_NUM=0x2207
>  CONFIG_USB_GADGET_PRODUCT_NUM=0x320a
>  CONFIG_USB_GADGET_DWC2_OTG=y
> -CONFIG_USB_FUNCTION_MASS_STORAGE=y
>  CONFIG_USB_HOST_ETHER=y
>  CONFIG_USB_ETHER_ASIX=y
>  CONFIG_USB_ETHER_SMSC95XX=y
> diff --git a/configs/phycore-rk3288_defconfig b/configs/phycore-rk3288_defconfig
> index 7503417e6a..41b9c139a9 100644
> --- a/configs/phycore-rk3288_defconfig
> +++ b/configs/phycore-rk3288_defconfig
> @@ -27,6 +27,7 @@ CONFIG_CMD_MMC=y
>  CONFIG_CMD_SF=y
>  CONFIG_CMD_SPI=y
>  CONFIG_CMD_USB=y
> +CONFIG_CMD_USB_MASS_STORAGE=y
>  # CONFIG_CMD_SETEXPR is not set
>  CONFIG_CMD_CACHE=y
>  CONFIG_CMD_TIME=y
> @@ -79,7 +80,6 @@ CONFIG_USB_GADGET_MANUFACTURER="Rockchip"
>  CONFIG_USB_GADGET_VENDOR_NUM=0x2207
>  CONFIG_USB_GADGET_PRODUCT_NUM=0x320a
>  CONFIG_USB_GADGET_DWC2_OTG=y
> -CONFIG_USB_FUNCTION_MASS_STORAGE=y
>  CONFIG_USB_HOST_ETHER=y
>  CONFIG_USB_ETHER_ASIX=y
>  CONFIG_USB_ETHER_SMSC95XX=y
> diff --git a/configs/popmetal-rk3288_defconfig b/configs/popmetal-rk3288_defconfig
> index ac507298a7..c829fbd815 100644
> --- a/configs/popmetal-rk3288_defconfig
> +++ b/configs/popmetal-rk3288_defconfig
> @@ -25,6 +25,7 @@ CONFIG_CMD_MMC=y
>  CONFIG_CMD_SF=y
>  CONFIG_CMD_SPI=y
>  CONFIG_CMD_USB=y
> +CONFIG_CMD_USB_MASS_STORAGE=y
>  # CONFIG_CMD_SETEXPR is not set
>  CONFIG_CMD_CACHE=y
>  CONFIG_CMD_TIME=y
> @@ -75,7 +76,6 @@ CONFIG_USB_GADGET_MANUFACTURER="Rockchip"
>  CONFIG_USB_GADGET_VENDOR_NUM=0x2207
>  CONFIG_USB_GADGET_PRODUCT_NUM=0x320a
>  CONFIG_USB_GADGET_DWC2_OTG=y
> -CONFIG_USB_FUNCTION_MASS_STORAGE=y
>  CONFIG_USB_HOST_ETHER=y
>  CONFIG_USB_ETHER_ASIX=y
>  CONFIG_USB_ETHER_SMSC95XX=y
> diff --git a/configs/rock2_defconfig b/configs/rock2_defconfig
> index 24ad3e9285..87eb564a9e 100644
> --- a/configs/rock2_defconfig
> +++ b/configs/rock2_defconfig
> @@ -24,6 +24,7 @@ CONFIG_CMD_MMC=y
>  CONFIG_CMD_SF=y
>  CONFIG_CMD_SPI=y
>  CONFIG_CMD_USB=y
> +CONFIG_CMD_USB_MASS_STORAGE=y
>  # CONFIG_CMD_SETEXPR is not set
>  CONFIG_CMD_CACHE=y
>  CONFIG_CMD_TIME=y
> @@ -76,7 +77,6 @@ CONFIG_USB_GADGET_MANUFACTURER="Rockchip"
>  CONFIG_USB_GADGET_VENDOR_NUM=0x2207
>  CONFIG_USB_GADGET_PRODUCT_NUM=0x320a
>  CONFIG_USB_GADGET_DWC2_OTG=y
> -CONFIG_USB_FUNCTION_MASS_STORAGE=y
>  CONFIG_DM_VIDEO=y
>  CONFIG_DISPLAY=y
>  CONFIG_VIDEO_ROCKCHIP=y
> diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig
> index 85ef9dabbd..92f5b1ebaa 100644
> --- a/configs/tinker-rk3288_defconfig
> +++ b/configs/tinker-rk3288_defconfig
> @@ -26,6 +26,7 @@ CONFIG_CMD_MMC=y
>  CONFIG_CMD_SF=y
>  CONFIG_CMD_SPI=y
>  CONFIG_CMD_USB=y
> +CONFIG_CMD_USB_MASS_STORAGE=y
>  # CONFIG_CMD_SETEXPR is not set
>  CONFIG_CMD_CACHE=y
>  CONFIG_CMD_TIME=y
> @@ -78,7 +79,6 @@ CONFIG_USB_GADGET_MANUFACTURER="Rockchip"
>  CONFIG_USB_GADGET_VENDOR_NUM=0x2207
>  CONFIG_USB_GADGET_PRODUCT_NUM=0x320a
>  CONFIG_USB_GADGET_DWC2_OTG=y
> -CONFIG_USB_FUNCTION_MASS_STORAGE=y
>  CONFIG_USB_HOST_ETHER=y
>  CONFIG_USB_ETHER_ASIX=y
>  CONFIG_USB_ETHER_SMSC95XX=y
> diff --git a/include/configs/rk3036_common.h b/include/configs/rk3036_common.h
> index aa7ca75c7d..46343148f2 100644
> --- a/include/configs/rk3036_common.h
> +++ b/include/configs/rk3036_common.h
> @@ -32,7 +32,6 @@
>  /* usb otg */
>  
>  /* usb mass storage */
> -#define CONFIG_CMD_USB_MASS_STORAGE

This is leaving empty comments which serve no purpose. Looks like the
same has happened above for when the usb otg parts got moved. Ditto for
the other files below.

Cheers,
Jack.

>  
>  /* usb host */
>  #define ENV_MEM_LAYOUT_SETTINGS \
> diff --git a/include/configs/rk322x_common.h b/include/configs/rk322x_common.h
> index e72aa8d2d3..4392614d71 100644
> --- a/include/configs/rk322x_common.h
> +++ b/include/configs/rk322x_common.h
> @@ -33,7 +33,6 @@
>  /* usb otg */
>  
>  /* usb mass storage */
> -#define CONFIG_CMD_USB_MASS_STORAGE
>  
>  /* usb host */
>  #define ENV_MEM_LAYOUT_SETTINGS \
> diff --git a/include/configs/rk3288_common.h b/include/configs/rk3288_common.h
> index 72a54bc0ab..d5efbaa99e 100644
> --- a/include/configs/rk3288_common.h
> +++ b/include/configs/rk3288_common.h
> @@ -44,7 +44,6 @@
>  /* usb otg */
>  
>  /* usb mass storage */
> -#define CONFIG_CMD_USB_MASS_STORAGE
>  
>  /* usb host support */
>  #define ENV_MEM_LAYOUT_SETTINGS \
> diff --git a/include/configs/vyasa-rk3288.h b/include/configs/vyasa-rk3288.h
> index 382fdac4c0..3574a3b5a5 100644
> --- a/include/configs/vyasa-rk3288.h
> +++ b/include/configs/vyasa-rk3288.h
> @@ -17,7 +17,6 @@
>  	func(MMC, mmc, 1) \
>  
>  #define CONFIG_SYS_MMC_ENV_DEV 1
> -#undef CONFIG_CMD_USB_MASS_STORAGE
>  
>  #ifndef CONFIG_TPL_BUILD
>  
> 


More information about the U-Boot mailing list