[U-Boot] [linux-sunxi] [PATCH 3/3] arm: sunxi: Enable DRAM ODT by default on H3/H5

[Jagan Teki]

On Wed, Apr 3, 2019 at 1:23 PM Paul Kocialkowski
<paul.kocialkowski at bootlin.com> wrote:
>
> Hi,
>
> Le mercredi 03 avril 2019 à 13:09 +0530, Jagan Teki a écrit :
> > On Thu, Mar 14, 2019 at 4:07 PM Paul Kocialkowski
> > <paul.kocialkowski at bootlin.com> wrote:
> > > Most of the boards we support with H3/H5 enable DRAM on-die termination,
> > > which is consistent with the high DRAM clocks that are used.
> > >
> > > Make it the default (like it's done for other similar platforms) instead
> > > of defining it in each defconfig.
> > >
> > > Signed-off-by: Paul Kocialkowski <paul.kocialkowski at bootlin.com>
> > > ---
> > >  arch/arm/mach-sunxi/Kconfig                   | 1 +
> > >  configs/bananapi_m2_plus_h3_defconfig         | 1 -
> > >  configs/bananapi_m2_plus_h5_defconfig         | 1 -
> > >  configs/bananapi_m2_zero_defconfig            | 1 -
> > >  configs/emlid_neutis_n5_devboard_defconfig    | 1 +
> > >  configs/libretech_all_h3_cc_h2_plus_defconfig | 1 -
> > >  configs/libretech_all_h3_cc_h3_defconfig      | 1 -
> > >  configs/libretech_all_h3_cc_h5_defconfig      | 1 -
> > >  configs/nanopi_m1_defconfig                   | 1 -
> > >  configs/nanopi_m1_plus_defconfig              | 1 -
> > >  configs/nanopi_neo2_defconfig                 | 1 +
> > >  configs/nanopi_neo_air_defconfig              | 1 -
> > >  configs/nanopi_neo_defconfig                  | 1 -
> > >  configs/nanopi_neo_plus2_defconfig            | 1 +
> > >  configs/orangepi_2_defconfig                  | 1 -
> > >  configs/orangepi_lite_defconfig               | 1 -
> > >  configs/orangepi_one_defconfig                | 1 -
> > >  configs/orangepi_pc2_defconfig                | 1 +
> > >  configs/orangepi_pc_defconfig                 | 1 -
> > >  configs/orangepi_pc_plus_defconfig            | 1 -
> > >  configs/orangepi_plus2e_defconfig             | 1 -
> > >  configs/orangepi_plus_defconfig               | 1 -
> > >  configs/orangepi_prime_defconfig              | 1 +
> > >  configs/orangepi_r1_defconfig                 | 1 -
> > >  configs/orangepi_zero_defconfig               | 1 -
> > >  configs/orangepi_zero_plus2_defconfig         | 1 +
> > >  configs/orangepi_zero_plus_defconfig          | 1 +
> > >  27 files changed, 8 insertions(+), 19 deletions(-)
>
> [...]
>
> > > diff --git a/configs/orangepi_zero_plus_defconfig b/configs/orangepi_zero_plus_defconfig
> > > index cc8b8c7f9ab9..37ca6dff374f 100644
> > > --- a/configs/orangepi_zero_plus_defconfig
> > > +++ b/configs/orangepi_zero_plus_defconfig
> > > @@ -4,6 +4,7 @@ CONFIG_SPL=y
> > >  CONFIG_MACH_SUN50I_H5=y
> > >  CONFIG_DRAM_CLK=624
> > >  CONFIG_DRAM_ZQ=3881977
> > > +# CONFIG_DRAM_ODT_EN is not set
> >
> > Why ODT not enabled these boards?
>
> Because the config wasn't set before on these boards and I don't want
> to change the DRAM configuration of any board without testing.
>
> It's very likely that enabling ODT would be a good idea on these boards
> too, but someone needs to test that before making the change.

OK, let me test check it from my end.