[U-Boot] [PATCH 2/3] i2c: muxes: pca954x: clarify enable field

Michal Simek michal.simek at xilinx.com
Fri Apr 5 10:57:06 UTC 2019


On 05. 04. 19 12:32, Luca Ceresoli wrote:
> The chip_desc.enable field is used only for muxes, not tor switches.

typo tor.

M

> Document it and remove the unused values.
> 
> Signed-off-by: Luca Ceresoli <luca at lucaceresoli.net>
> ---
>  drivers/i2c/muxes/pca954x.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/muxes/pca954x.c b/drivers/i2c/muxes/pca954x.c
> index bd4e9abe5f3c..5669753ce14d 100644
> --- a/drivers/i2c/muxes/pca954x.c
> +++ b/drivers/i2c/muxes/pca954x.c
> @@ -22,7 +22,7 @@ enum pca_type {
>  };
>  
>  struct chip_desc {
> -	u8 enable;
> +	u8 enable; /* Enable mask in ctl register (used for muxes only) */
>  	enum muxtype {
>  		pca954x_ismux = 0,
>  		pca954x_isswi,
> @@ -48,12 +48,10 @@ static const struct chip_desc chips[] = {
>  		.width = 8,
>  	},
>  	[PCA9548] = {
> -		.enable = 0x8,
>  		.muxtype = pca954x_isswi,
>  		.width = 8,
>  	},
>  	[PCA9646] = {
> -		.enable = 0x0,
>  		.muxtype = pca954x_isswi,
>  		.width = 4,
>  	},
> 



More information about the U-Boot mailing list