[U-Boot] [PATCH 2/2] cmd: Add 'bcb' command to read/modify/write BCB fields

Eugeniu Rosca roscaeugeniu at gmail.com
Sun Apr 7 22:43:39 UTC 2019


Hi Heinrich,

On Mon, Apr 08, 2019 at 12:11:59AM +0200, Heinrich Schuchardt wrote:
[..]
> > +	switch (bcb_cmd_get(argv[0])) {
> > +	case BCB_CMD_LOAD:
> > +		return bcb_load(argc, argv, &bcb, &bcb_dev, &bcb_part);
> > +	case BCB_CMD_FIELD_SET:
> > +		return bcb_field_set(argc, argv, &bcb, bcb_dev, bcb_part);
> > +	case BCB_CMD_FIELD_CLEAR:
> > +		return bcb_field_clear(argc, argv, &bcb, bcb_dev, bcb_part);
> > +	case BCB_CMD_FIELD_TEST:
> > +		return bcb_field_test(argc, argv, &bcb, bcb_dev, bcb_part);
> > +	case BCB_CMD_FIELD_DUMP:
> > +		return bcb_field_dump(argc, argv, &bcb, bcb_dev, bcb_part);
> > +	case BCB_CMD_STORE:
> > +		return bcb_store(argc, argv, &bcb, bcb_dev, bcb_part);
> > +	default:
> > +		return CMD_RET_USAGE;
> > +	}
> 
> Please, implement the sub-commands as described in doc/README.commands
> using the U_BOOT_CMD_MKENT macro.

Thanks for the lightning-fast reply. Will fix in v2, once hopefully
more review comments are collected.

> Best regards
> 
> Heinrich

Best regards,
Eugeniu.


More information about the U-Boot mailing list