[U-Boot] [PATCH] ARM: dts: i.MX6ULL: U-Boot specific dts for u-boot, dm-spl

Marcel Ziswiler marcel.ziswiler at toradex.com
Mon Apr 8 13:53:20 UTC 2019


Hi Parthiban

On Sun, 2019-04-07 at 20:32 +0200, Parthiban Nallathambi wrote:
> u-boot,dm-spl property is specific to U-Boot, so created one
> for i.MX6ULL platforms.

What exactly makes you so sure others do want your exact configuration
thereof as well? Shouldn't you make this board specific instead like
e.g. done elsewhere [1]?

[1] 
https://git.denx.de/?p=u-boot.git;a=blob;f=arch/arm/dts/am335x-chiliboard-u-boot.dtsi;h=4f9d3080394be001f79731b736c5eac934c07ebf;hb=HEAD

Cheers

Marcel

> Signed-off-by: Parthiban Nallathambi <parthitce at gmail.com>
> ---
>  arch/arm/dts/imx6ull-u-boot.dtsi | 34
> ++++++++++++++++++++++++++++++++
>  board/phytec/pcl063/MAINTAINERS  |  1 +
>  2 files changed, 35 insertions(+)
>  create mode 100644 arch/arm/dts/imx6ull-u-boot.dtsi
> 
> diff --git a/arch/arm/dts/imx6ull-u-boot.dtsi b/arch/arm/dts/imx6ull-
> u-boot.dtsi
> new file mode 100644
> index 0000000000..74ca95fa2c
> --- /dev/null
> +++ b/arch/arm/dts/imx6ull-u-boot.dtsi
> @@ -0,0 +1,34 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2019 Parthiban Nallathambi <parthitce at gmail.com>
> + */
> +
> +/ {
> +	soc {
> +		u-boot,dm-spl;
> +	};
> +};
> +
> +&aips1 {
> +	u-boot,dm-spl;
> +};
> +
> +&aips2 {
> +	u-boot,dm-spl;
> +};
> +
> +&aips3 {
> +	u-boot,dm-spl;
> +};
> +
> +&gpio1 {
> +	u-boot,dm-spl;
> +};
> +
> +&gpio4 {
> +	u-boot,dm-spl;
> +};
> +
> +&iomuxc {
> +	u-boot,dm-spl;
> +};
> diff --git a/board/phytec/pcl063/MAINTAINERS
> b/board/phytec/pcl063/MAINTAINERS
> index 70e03cfe71..7d9978c339 100644
> --- a/board/phytec/pcl063/MAINTAINERS
> +++ b/board/phytec/pcl063/MAINTAINERS
> @@ -3,6 +3,7 @@ M:	Martyn Welch <martyn.welch at collabora.com>
>  M:	Parthiban Nallathambi <parthitce at gmail.com>
>  S:	Maintained
>  F:	arch/arm/dts/imx6ul-phycore-segin.dts
> +F:	arch/arm/dts/imx6ull-u-boot.dtsi
>  F:	arch/arm/dts/imx6ull-phycore-segin.dts
>  F:	arch/arm/dts/pcl063-common.dtsi
>  F:	board/phytec/pcl063/


More information about the U-Boot mailing list