[U-Boot] [PATCH 3/3] common: bouncebuf: handle address in sram for rockchip platform

[Heiko Stübner]

Hi Kever,

Am Dienstag, 2. April 2019, 10:46:54 CEST schrieb Kever Yang:
> Rockchip SOC's mmc controller does not support read data
> from mmc to sram, we need a bounce buffer(in sdram), and then
> copy to sram.
> 
> Signed-off-by: Kever Yang <kever.yang at rock-chips.com>
> ---
> 
>  common/bouncebuf.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/common/bouncebuf.c b/common/bouncebuf.c
> index a7098e2caf..364fb17c96 100644
> --- a/common/bouncebuf.c
> +++ b/common/bouncebuf.c
> @@ -26,6 +26,18 @@ static int addr_aligned(struct bounce_buffer *state)
>  		return 0;
>  	}
>  
> +#ifdef CONFIG_ARCH_ROCKCHIP
> +	/*
> +	 * Rockchip SOC's mmc controller does not support read data
> +	 * from mmc to sram, we need a bounce buffer(in sdram), and then
> +	 * copy to sram.
> +	 */
> +	if (((ulong)state->user_buffer & 0xfff80000) ==
> +	    CONFIG_ROCKCHIP_IRAM_BASE) {
> +		debug("Unsupport IRAM space %p\n", state->user_buffer);
> +		return 0;
> +	}

wouldn't it be easier to just check for "in-ddr-region"?
Rockchip SoCs may have multiple sram areas one might want to use.

Also I get the feeling this should not live in an ARCH_ROCKCHIP ifdef.
Instead maybe define some sort of kconfig settings to describe the
directly usable memory areas, that the bounce_buffer then could use?


Heiko

> +#endif
>  	/* Aligned */
>  	return 1;
>  }
>