[U-Boot] [PATCH 1/1] test: call hexdump tests via `ut lib`

Heinrich Schuchardt xypron.glpk at gmx.de
Wed Apr 10 00:08:36 UTC 2019


On 2/11/19 8:42 PM, Simon Goldschmidt wrote:
> Am 11.02.2019 um 18:29 schrieb Heinrich Schuchardt:
>> The unit tests in test/lib/hexdump.c are not related to the device tree.
>> So they should be executed via `ut lib` and not via `ut dm`.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>
> Reviewed-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>

Hello Tom,

please, consider the patch for v2019-07.

Best regards

Heinrich

>
> Excellent idea, I'll send the same for test/lib/lmb.c.
>
> Thanks,
> Simon
>
>> ---
>>   test/lib/hexdump.c | 9 +++++----
>>   1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/test/lib/hexdump.c b/test/lib/hexdump.c
>> index 567b57686a..5dccf43886 100644
>> --- a/test/lib/hexdump.c
>> +++ b/test/lib/hexdump.c
>> @@ -6,7 +6,8 @@
>>     #include <common.h>
>>   #include <hexdump.h>
>> -#include <dm/test.h>
>> +#include <test/lib.h>
>> +#include <test/test.h>
>>   #include <test/ut.h>
>>     static int lib_test_hex_to_bin(struct unit_test_state *uts)
>> @@ -32,7 +33,7 @@ static int lib_test_hex_to_bin(struct
>> unit_test_state *uts)
>>       return 0;
>>   }
>>   -DM_TEST(lib_test_hex_to_bin, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
>> +LIB_TEST(lib_test_hex_to_bin, 0);
>>     static int lib_test_hex2bin(struct unit_test_state *uts)
>>   {
>> @@ -62,7 +63,7 @@ static int lib_test_hex2bin(struct unit_test_state
>> *uts)
>>       return 0;
>>   }
>>   -DM_TEST(lib_test_hex2bin, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
>> +LIB_TEST(lib_test_hex2bin, 0);
>>     static int lib_test_bin2hex(struct unit_test_state *uts)
>>   {
>> @@ -92,4 +93,4 @@ static int lib_test_bin2hex(struct unit_test_state
>> *uts)
>>       return 0;
>>   }
>>   -DM_TEST(lib_test_bin2hex, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
>> +LIB_TEST(lib_test_bin2hex, 0);
>>
>
>



More information about the U-Boot mailing list