[U-Boot] [PATCH] timer: dw-apb: Add missing 64bit up-conversion

Simon Goldschmidt simon.k.r.goldschmidt at gmail.com
Thu Apr 11 07:40:24 UTC 2019


On Thu, Apr 11, 2019 at 9:22 AM Marek Vasut <marex at denx.de> wrote:
>
> On 4/11/19 8:25 AM, Simon Goldschmidt wrote:
> > On Wed, Apr 10, 2019 at 2:01 PM Marek Vasut <marex at denx.de> wrote:
> >>
> >> The generic timer count is an incrementing 64bit value and a timer driver
> >> must return an incrementing 64bit value. The DW APB timer only provides a
> >> 32bit timer counting down, thus the result must be inverted and converted
> >> to a 64bit value. The current implementation is however missing the 64bit
> >> up-conversion and this results in random timer roll-overs, which in turn
> >> triggers random timeouts throughout the codebase.
> >>
> >> This patch adds the missing 64bit up-conversion to fix the issue.
> >>
> >> Signed-off-by: Marek Vasut <marex at denx.de>
> >> Cc: Chin Liang See <chin.liang.see at intel.com>
> >> Cc: Dinh Nguyen <dinguyen at kernel.org>
> >> Cc: Ley Foon Tan <ley.foon.tan at intel.com>
> >> Cc: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
> >> Cc: Tien Fong Chee <tien.fong.chee at intel.com>
> >
> > Reviewed-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
>
> Maybe it's time to convert Gen5 to this timer driver too :)

Yes, well, let's see when I find the time. Converting clock and pinctrl to
devicetree is on my list as well...

Regards,
Simon


More information about the U-Boot mailing list