[U-Boot] [PATCH] turris_omnia: fix eeprom/mcu device names

Stefan Roese sr at denx.de
Thu Apr 11 08:49:54 UTC 2019


Hi Pierre,

On 11.04.19 01:00, Pierre Bourdon wrote:
> Commit c4bd12a7dad4 ("i2c: mux: Generate longer i2c mux name") changed
> the naming scheme of i2c devices within a mux. This broke references to
> i2c at 0 in the Turris Omnia board initialization code.
> 
> Signed-off-by: Pierre Bourdon <delroth at gmail.com>
> Cc: Marek BehĂșn <marek.behun at nic.cz>
> ---
>   board/CZ.NIC/turris_omnia/turris_omnia.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
> index c7f6479a0c..c54cd047c1 100644
> --- a/board/CZ.NIC/turris_omnia/turris_omnia.c
> +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
> @@ -32,13 +32,13 @@
>   
>   DECLARE_GLOBAL_DATA_PTR;
>   
> -#define OMNIA_I2C_EEPROM_DM_NAME	"i2c at 0"
> +#define OMNIA_I2C_EEPROM_DM_NAME	"i2c at 11000->i2cmux at 70->i2c at 0"
>   #define OMNIA_I2C_EEPROM		0x54
>   #define OMNIA_I2C_EEPROM_CONFIG_ADDR	0x0
>   #define OMNIA_I2C_EEPROM_ADDRLEN	2
>   #define OMNIA_I2C_EEPROM_MAGIC		0x0341a034
>   
> -#define OMNIA_I2C_MCU_DM_NAME		"i2c at 0"
> +#define OMNIA_I2C_MCU_DM_NAME		"i2c at 11000->i2cmux at 70->i2c at 0"
>   #define OMNIA_I2C_MCU_ADDR_STATUS	0x1
>   #define OMNIA_I2C_MCU_SATA		0x20
>   #define OMNIA_I2C_MCU_CARDDET		0x10
> 

Look good, so:

Reviewed-by: Stefan Roese <sr at denx.de>

Please use "arm: mvebu: turris_omnia: ..." as the patch subject next
time and Cc me (or the corresponding subsystem maintainer) next time.
No need to re-send now.

Thanks,
Stefan


More information about the U-Boot mailing list