[U-Boot] [PATCH 1/1] efi_loader: enable HII protocols by default

[AKASHI Takahiro]

On Mon, Apr 08, 2019 at 12:03:01AM +0200, Heinrich Schuchardt wrote:
> As the UEFI shell requires the HII protocols let's enable them by default.

Is there still any reason that we have this config option at all?

> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
>  lib/efi_loader/Kconfig | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> index 23487b8130..a6489ca534 100644
> --- a/lib/efi_loader/Kconfig
> +++ b/lib/efi_loader/Kconfig
> @@ -38,14 +38,11 @@ config EFI_LOADER_BOUNCE_BUFFER
>  config EFI_LOADER_HII
>  	bool "Expose HII protocols to EFI applications"
>  	depends on EFI_LOADER
> -	default n
> +	default y
>  	help
>  	  The Human Interface Infrastructure is a complicated framework that
>  	  allows UEFI applications to draw fancy menus and hook strings using
>  	  a translation framework.
> 
>  	  U-Boot implements enough of its features to be able to run the UEFI
> -	  Shell, but not more than that. The code is experimental still, so
> -	  beware that your system might break with HII enabled.

I don't think it's experimental, but just not fully implemented
in terms of UEFI specification. This is also true for other UEFI features
on U-Boot.
Since a some kind of bug regarding HII was reported, I haven't seen
any bug fix relating to that. (I doubt it was a bug.)

-Takahiro Akashi

> -	  If unsure, say n.
> +	  Shell, but not more than that.
> --
> 2.20.1
>