[U-Boot] [PATCH] mtd: spi: Replace ad-hoc default implementation with spi_mem_op

[Jagan Teki]

On Wed, Apr 10, 2019 at 12:14 PM Marek Vasut <marek.vasut at gmail.com> wrote:
>
> On 4/4/19 8:10 AM, Ashish Kumar wrote:
> >
> >
> >> -----Original Message-----
> >> From: Vignesh Raghavendra <vigneshr at ti.com>
> >> Sent: Tuesday, April 2, 2019 10:04 AM
> >> To: Marek Vasut <marek.vasut at gmail.com>; u-boot at lists.denx.de
> >> Cc: Marek Vasut <marek.vasut+renesas at gmail.com>; Horatiu Vultur
> >> <horatiu.vultur at microchip.com>; Jagan Teki <jagan at openedev.com>; Simon
> >> Goldschmidt <simon.k.r.goldschmidt at gmail.com>; Stefan Roese <sr at denx.de>;
> >> Ashish Kumar <ashish.kumar at nxp.com>
> >> Subject: Re: [PATCH] mtd: spi: Replace ad-hoc default implementation with
> >> spi_mem_op
> >>
> >> + Ashish,
> >>
> >> On 02/04/19 6:22 AM, Marek Vasut wrote:
> >>> Replace the ad-hoc erase operation implementation with a simple
> >>> spi_mem_op implementation of the same functionality. This is a minor
> >>> optimization and removal of the ad-hoc code.
> >>>
> >>> This however also changes the behavior of the execution of the erase
> >>> opcode from two separate transfer requests to the SPI NOR driver to
> >>> one transfer request to the SPI NOR driver. The former was how U-Boot
> >>> behaved before the SPI NOR framework was imported and the later was
> >>> introduced by the SPI NOR framework. The former is more optimal, so
> >>> keep that.
> >>>
> >>> Signed-off-by: Marek Vasut <marek.vasut+renesas at gmail.com>
> >>> Cc: Horatiu Vultur <horatiu.vultur at microchip.com>
> >>> Cc: Jagan Teki <jagan at openedev.com>
> >>> Cc: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
> >>> Cc: Stefan Roese <sr at denx.de>
> >>> Cc: Vignesh R <vigneshr at ti.com>
> >>> ---
> >>
> >> Marek, thanks for the fix!
> >>
> >> Jagan,
> >>
> >> Could we get this merged before v2019.04 release as this should fix regression
> >> wrt erase reported by Ashish.
> >
> >
> > Yes, follow patch reverts back to old method of erase implementation.
> > Tested-by: Ashish Kumar <Ashish.kumar at nxp.com>
>
> I guess this never made it into the release, so the SPI NOR erase is
> broken in v2019.04 ?

I usually review on top of patchwork, that seems not assigned to me.
Vignesh will this break? I can see the erase seems fine on my microzed
with last week testing.