[U-Boot] [PATCH 2/2] at91: cleanup taurus port

[Eugen.Hristev at microchip.com]

On 12.04.2019 15:53, Heiko Schocher wrote:
> External E-Mail
> 
> 
> Hello eugen,
> 
> Am 12.04.2019 um 13:24 schrieb Eugen.Hristev at microchip.com:
>>
>>
>> On 11.04.2019 08:53, Heiko Schocher wrote:
>>
>>>
>>> - at91sam9g20-taurus.dts: use labels
>>> - cleanup taurus port to compile clean with
>>>     current mainline again. SPL has no serial
>>>     output anymore, so it fits into SRAM.
>>>
>>> Signed-off-by: Heiko Schocher <hs at denx.de>
>>
>> [snip]
>>
>> Hello Heiko,
>>
>> This patch has several issues:
>>
>> taurus_defconfig
>>
>> +spl/dts/dt-platdata.c:11:46: error: missing braces around initializer
>> [-Werror=missing-braces]
>> + static const struct dtd_simple_bus dtv_ahb = {
>> +                                              ^
>> +spl/dts/dt-platdata.c:20:46: error: missing braces around initializer
>> [-Werror=missing-braces]
>> + static const struct dtd_simple_bus dtv_apb = {
>> +cc1: all warnings being treated as errors
>> +make[2]: *** [spl/dts/dt-platdata.o] Error 1
>> +make[1]: *** [spl/u-boot-spl] Error 2
>> +make: *** [sub-make] Error 2
> 
> Ah, I had not warnings as errors active ... sorry for this!
> 
> Hmmm:
> 
> in generated ./include/generated/dt-structs-gen.h
> 
> struct dtd_simple_bus {
>          bool            ranges;
> };

True but at line #44 you have

#define dtd_simple_bus dtd_atmel_at91rm9200_pinctrl

Which redefines things...

> 
> and in spl/dts/dt-platdata.c:
> 
> #include <dt-structs.h>
> 
> static const struct dtd_simple_bus dtv_ahb = {
>          .ranges                 = true,
> };
> 
> Do not see what is really wrong ... may friday afternoon ...
> 
>> and axm_defconfig :
>>
>> +drivers/built-in.o: In function `get_current':
>> +drivers/serial/serial.c:318: undefined reference to
>> `default_serial_console'
>> +make[2]: *** [spl/u-boot-spl] Error 1
>> +make[1]: *** [spl/u-boot-spl] Error 2
>> +make: *** [sub-make] Error 2
> 
> Ups, sorry, just forgot to add this, update this in v2.
> 
> Thanks for the review!
> 
> bye,
> Heiko