[U-Boot] [PATCH] [U-boot]: Change FDT memory type from runtime data to boot services data

Heinrich Schuchardt xypron.glpk at gmx.de
Fri Apr 12 19:30:03 UTC 2019


On 4/12/19 8:26 PM, Ilias Apalodimas wrote:
> Following Ard's suggestion:
> Runtime data sections are intended for data that is used by the runtime
> services implementation.
> Let's change the type to EFI_BOOT_SERVICES_DATA
>
> This also fixes booting of armv7 using efi and fdtcontroladdr
>
> Suggested-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>
> Acked-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>

EfiBootServicesData is used by EDK II for installing the FDT.
GRUB uses EfiLoaderCode when installing its modified version of the FDT.

Reviewed-by: Heinrich Schuchardt <xypron.glpk at gmx.de>

> ---
>   cmd/bootefi.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cmd/bootefi.c b/cmd/bootefi.c
> index 3619a20e6433..15ee4af45667 100644
> --- a/cmd/bootefi.c
> +++ b/cmd/bootefi.c
> @@ -111,13 +111,13 @@ static efi_status_t copy_fdt(void **fdtp)
>   	new_fdt_addr = (uintptr_t)map_sysmem(fdt_ram_start + 0x7f00000 +
>   					     fdt_size, 0);
>   	ret = efi_allocate_pages(EFI_ALLOCATE_MAX_ADDRESS,
> -				 EFI_RUNTIME_SERVICES_DATA, fdt_pages,
> +				 EFI_BOOT_SERVICES_DATA, fdt_pages,
>   				 &new_fdt_addr);
>   	if (ret != EFI_SUCCESS) {
>   		/* If we can't put it there, put it somewhere */
>   		new_fdt_addr = (ulong)memalign(EFI_PAGE_SIZE, fdt_size);
>   		ret = efi_allocate_pages(EFI_ALLOCATE_MAX_ADDRESS,
> -					 EFI_RUNTIME_SERVICES_DATA, fdt_pages,
> +					 EFI_BOOT_SERVICES_DATA, fdt_pages,
>   					 &new_fdt_addr);
>   		if (ret != EFI_SUCCESS) {
>   			printf("ERROR: Failed to reserve space for FDT\n");
>


More information about the U-Boot mailing list