[U-Boot] doing anything about "bad" Kbuild configuration options?

[Chris Packham]

On Sat, 13 Apr 2019, 4:56 AM Robert P. J. Day, <rpjday at crashcourse.ca>
wrote:

>   one of the worst culprits appears to be CONFIG_SPL_BUILD, which
> appears all over the tree, but one can see a recent commit that takes
> that into account:
>

That's not quite right. CONFIG_SPL_BUILD is defined for the Makefile just
not in Kconfig (I'm on a tablet right now so I can't point you to the
source).

  commit 0ef692084363f2de8547db93397c6a69123d26ca
>   Author: Baruch Siach <baruch at tkos.co.il>
>   Date:   Thu Feb 7 13:21:16 2019 +0200
>
>     Kconfig: fix BUILD_TARGET for ARCH_MVEBU
>
>     Commit dc146ca11187 ("Kconfig: Migrate CONFIG_BUILD_TARGET") made the
>     mvebu default build target depend on CONFIG_SPL_BUILD. Unfortunately,
>     there is no such Kconfig symbol. Use the CONFIG_SPL symbol instead to
>     fix that.
>
>     Cc: Jagan Teki <jagan at amarulasolutions.com>
>     Signed-off-by: Baruch Siach <baruch at tkos.co.il>
>     Reviewed-by: Stefan Roese <sr at denx.de>
>     Reviewed-by: Jagan Teki <jagan at amarulasolutions.com>
>     Signed-off-by: Stefan Roese <sr at denx.de>
>

This commit addresses the fact that CONFIG_SPL_BUILD is not available to
use in Kconfig. It is available to Makefiles, I can't remember if it gets
defined for source files.

>