[U-Boot] [U-Boot, PATCHv4, 3/6] dm: cache: Create a uclass for cache

[Tom Rini]

On Mon, Apr 01, 2019 at 05:32:17PM -0500, Dinh Nguyen wrote:

> The cache UCLASS will be used for configure settings that can be found
> in a CPU's L2 cache controller.
> 
> Add a uclass and a test for cache.
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> Signed-off-by: Dinh Nguyen <dinguyen at kernel.org>
> ---
> v4: re-order includes and add Reviewed-by:
> v3: Add cache_get_info() to check for non-zero value
>     Add comments to cache_info struct
> v2: separate out uclass patch from driver and add test

NAK:
   sandbox:  +   tools-only
+(tools-only) In file included from drivers/cache/sandbox_cache.c:6:0:
+(tools-only) include/cache.h:13:2: error: unknown type name 'phys_addr_t'
+(tools-only)   phys_addr_t base; /* Base physical address of cache device. */
+(tools-only)   ^~~~~~~~~~~
+(tools-only)   int (*get_info)(struct udevice *dev, struct cache_info *info);
+(tools-only)                          ^~~~~~~
+(tools-only)  int cache_get_info(struct udevice *dev, struct cache_info *info);
+(tools-only)                            ^~~~~~~
+(tools-only)   .get_info = sandbox_get_info,
+(tools-only)               ^~~~~~~~~~~~~~~~
+(tools-only) drivers/cache/sandbox_cache.c:21:14: note: (near initialization for 'sandbox_cach
e_ops.get_info')
+(tools-only) make[3]: *** [drivers/cache/sandbox_cache.o] Error 1
+(tools-only) make[2]: *** [drivers/cache] Error 2
+(tools-only) make[1]: *** [drivers] Error 2
+(tools-only) make: *** [sub-make] Error 2
w+(tools-only) include/cache.h:24:25: warning: 'struct udevice' declared inside parameter list will not be visible outside of this definition or declaration
w+(tools-only) include/cache.h:36:27: warning: 'struct udevice' declared inside parameter list will not be visible outside of this definition or declaration
w+(tools-only) drivers/cache/sandbox_cache.c:21:14: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190422/3086a5a8/attachment.sig>