[U-Boot] [PATCH] spi: Zap lpc32xx_ssp driver-related code

Vladimir Zapolskiy vz at mleia.com
Mon Apr 22 20:50:22 UTC 2019


Hi Jagan, Tom,

On 04/19/2019 09:48 AM, Jagan Teki wrote:
> Dropped
> - lpc32xx_ssp driver
> - CONFIG_LPC32XX_SSP, LPC32XX_SSP_TIMEOUT items
> 
> Dropped due to:
> - no active updates
> - no dm conversion
> - multiple pings for asking dm-conversion

I really don't want to rush into moaning, however let me ask you to drop
the reason given above as invalid, otherwise please clarify who were
the addressees of these 'multiple pings'.

> - no response for dm converted patch

I believe there was no DM conversion patch for this particular driver,
could it happen that I've missed it?

> - driver-model migration expiry
> 

Definitely this is a valid reason.

The good news is that I don't have any strong objection against
the deletion of the driver.

Why? Recently Quentin Schulz added drivers/spi/pl022_spi.c, and it
provides a support of right the same SPI controller, the new driver
satisfies DM policy.

Quentin, you may take a look at drivers/spi/lpc32xx_ssp.c before (or
after though) its removal for scavenging any goodies.

>From my side I'd like to test the new driver on one of my boards,
but unfortunately it may take indefinite time, because it will require
some tinkering. Nevertheless, if any LPC32xx specific changes will be
required, they'll be added to the new Quentin's driver.

--
Best wishes,
Vladimir


More information about the U-Boot mailing list