[U-Boot] relationship between "ARM_DCC" and "DEBUG_UART_ARM_DCC"?

[Robert P. J. Day]

On Tue, 23 Apr 2019, Michal Simek wrote:

> On 19. 04. 19 13:27, Robert P. J. Day wrote:
> >
> >   just noticed the oddness regarding those two Kbuild symbols:
> >
> > $ git grep ARM_DCC
> > arch/x86/include/asm/acpi_table.h:#define ACPI_DBG2_ARM_DCC   0x000F
> > configs/zynq_cse_qspi_defconfig:CONFIG_DEBUG_UART_ARM_DCC=y
> > drivers/serial/Kconfig:config DEBUG_UART_ARM_DCC
> > drivers/serial/Makefile:obj-$(CONFIG_ARM_DCC) += arm_dcc.o
> > drivers/serial/arm_dcc.c:#ifdef CONFIG_DEBUG_UART_ARM_DCC
> > include/configs/xilinx_versal.h:#define CONFIG_ARM_DCC
> > include/configs/xilinx_zynqmp.h:#define CONFIG_ARM_DCC
> > include/configs/zynq-common.h:#define CONFIG_ARM_DCC
> > scripts/config_whitelist.txt:CONFIG_ARM_DCC
> > $
> >
> >   strangely(?), there is a Kbuild config directive for the latter:
> >
> >   drivers/serial/Kconfig:config DEBUG_UART_ARM_DCC
> >
> > but not the former, which is just hardcoded in some xilinx-associated
> > header files. is this deliberate? it just seems ... weird.
>
> Simply none has had time to convert ARM_DCC to Kconfig that's why it
> is enabled via base platform. And because debug symbol is in Kconfig
> it is enabled for platform which needs it. Feel free to send a patch
> to move symbol there.

  ok, i can do that. i'm assuming the Kconfig file should define both
symbols:

  config ARM_DCC

and

  config DEBUG_UART_ARM_DCC
    depends on ARM_DCC

based on the current Makefile and arm_dcc.c file.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                         http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================