[U-Boot] [PATCH v2 3/7] tegra: sound: Add an audio hub driver

Simon Glass sjg at chromium.org
Wed Apr 24 03:54:19 UTC 2019


Hi Jon,

On Wed, 3 Apr 2019 at 03:05, Jon Hunter <jonathanh at nvidia.com> wrote:
>
>
> On 01/04/2019 21:38, Simon Glass wrote:
> > Add a driver for the audio hub. This is modelled as a misc device which
> > supports writing audio data from I2S.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> > Changes in v2:
> > - Fix 'I2C' typo
> >
> >  arch/arm/include/asm/arch-tegra/tegra_ahub.h | 475 +++++++++++++++++++
> >  drivers/sound/Kconfig                        |   9 +
> >  drivers/sound/Makefile                       |   1 +
> >  drivers/sound/tegra_ahub.c                   | 256 ++++++++++
> >  4 files changed, 741 insertions(+)
> >  create mode 100644 arch/arm/include/asm/arch-tegra/tegra_ahub.h
> >  create mode 100644 drivers/sound/tegra_ahub.c
> >
> > diff --git a/arch/arm/include/asm/arch-tegra/tegra_ahub.h
> > b/arch/arm/include/asm/arch-tegra/tegra_ahub.h
> > new file mode 100644
> > index 00000000000..96d542a91ca
> > --- /dev/null
> > +++ b/arch/arm/include/asm/arch-tegra/tegra_ahub.h
> > @@ -0,0 +1,475 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * tegra_ahub.h - Definitions for Tegra124 audio hub driver
> > + * Taken from dc tegra_ahub.h
> > + *
> > + * Copyright 2018 Google LLC
> > + * Copyright (c) 2013, NVIDIA CORPORATION.  All rights reserved.
> > + */
>
> Looks fine to me, although you may wish to update your copyright date
> now ;-)
>
> Acked-by: Jon Hunter <jonathanh at nvidia.com>

Feel free to update it when applying, but I'm OK with it. It's been
sitting around for a while!

Regards,
Simon


More information about the U-Boot mailing list