[U-Boot] [PATCH] rk8xx: implement poweroff
Simon Glass
sjg at chromium.org
Wed Apr 24 03:54:20 UTC 2019
Hi,
On Wed, 3 Apr 2019 at 06:21, Urja Rannikko <urjaman at gmail.com> wrote:
>
> Based on snooping around the linux kernel rk8xx driver, and
> tested to work on the ASUS C201.
>
> Signed-off-by: Urja Rannikko <urjaman at gmail.com>
> ---
> This is really handy to be able to poweroff (without pressing power button
> for a long time) the C201 from u-boot, so i'm sending this as is.
> The thing that is bothering me is the pmic_get --- i checked that
> every rk8xx is named "pmic" in the device tree so it should work, but
> it just feels really weird that this seems to be the best way to access
> the driver...
>
> drivers/power/pmic/rk8xx.c | 34 ++++++++++++++++++++++++++++++++++
> include/power/rk8xx_pmic.h | 4 ++++
> 2 files changed, 38 insertions(+)
This should really use a sysreset driver.
You can make the PMIC have a child sysreset driver to implement this function.
Regards,
Simon
More information about the U-Boot
mailing list