[U-Boot] [PATCH v4 0/4] arm: socfpga: clean up socfpga_common.h

Marek Vasut marex at denx.de
Wed Apr 24 17:42:07 UTC 2019


On 4/24/19 7:36 PM, Simon Goldschmidt wrote:
> Am 23.04.2019 um 23:24 schrieb Marek Vasut:
>> On 4/23/19 10:51 PM, Simon Goldschmidt wrote:
>>>
>>>
>>> Marek Vasut <marex at denx.de <mailto:marex at denx.de>> schrieb am Di., 23.
>>> Apr. 2019, 22:43:
>>>
>>>      On 4/23/19 9:36 PM, Simon Goldschmidt wrote:
>>>      > This series cleans up the include/configs/socfpga_common.h
>>> file a bit.
>>>      >
>>>      > It removes some defines that are used nowhere and cleans up some
>>>      > leftovers after various subsystems have been converted to use DM.
>>>      >
>>>      > Changes in v4:
>>>      > - fix DM_I2C case: don't call i2c_set_bus_num() since this is
>>>      >   done in cmd/eeprom already
>>>      >
>>>      > Changes in v3:
>>>      > - changed commit message: s/defines/macros and comments/
>>>      >
>>>      > Changes in v2:
>>>      > - added (this) patch to move socfpga_vining to DM_I2C
>>>      > - remove even more outdated things
>>>      > - added (this) patch with further cleanups to the socfpga
>>> board config
>>>      >   files
>>>      >
>>>      > Simon Goldschmidt (4):
>>>      >   arm: socfpga: move vining_fpga to DM_I2C
>>>      >   arm: socfpga: clean up socfpga_common.h
>>>      >   arm: socfpga: remove CONFIG_SYS_BOOTMAPSZ
>>>      >   arm: socfpga: clean up board config files
>>>      >
>>>      >  board/samtec/vining_fpga/socfpga.c       |  9 +---
>>>      >  configs/socfpga_vining_fpga_defconfig    |  8 ++-
>>>      >  include/configs/socfpga_arria10_socdk.h  |  6 ---
>>>      >  include/configs/socfpga_arria5_socdk.h   |  2 -
>>>      >  include/configs/socfpga_common.h         | 68
>>>      ------------------------
>>>      >  include/configs/socfpga_cyclone5_socdk.h |  2 -
>>>      >  include/configs/socfpga_de0_nano_soc.h   |  2 -
>>>      >  include/configs/socfpga_de10_nano.h      |  2 -
>>>      >  include/configs/socfpga_de1_soc.h        |  2 -
>>>      >  include/configs/socfpga_is1.h            |  2 -
>>>      >  include/configs/socfpga_sockit.h         |  2 -
>>>      >  include/configs/socfpga_socrates.h       |  2 -
>>>      >  include/configs/socfpga_sr1500.h         | 11 ----
>>>      >  include/configs/socfpga_vining_fpga.h    | 18 -------
>>>      >  14 files changed, 8 insertions(+), 128 deletions(-)
>>>
>>>      Neither of these apply to u-boot-socfpga/master :-(
>>>
>>>
>>> Sorry for the confusion, these are again meant to apply on top of other
>>> patches in a PR. Sent to the ML for reference, mainly, as the diffs are
>>> tiny.
>>>
>>> How should I mark such patches to prevent such misunderstandings in the
>>> future?
>>
>> Just send an incremental patch on top of u-boot-socfpga/master please .
>> If you want me to squash it into another patch, note it somewhere around
>> the diffstat.
>>
> 
> OK, in this case, drop this v4.

Cool, thanks.

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list