[U-Boot] [PATCH v2 1/4] drivers: pci_ep: Introduce UCLASS_PCI_EP uclass
Simon Glass
sjg at chromium.org
Wed Apr 24 23:33:44 UTC 2019
Hi Ramon,
On Wed, 24 Apr 2019 at 12:54, Ramon Fried <ramon.fried at gmail.com> wrote:
>
> Introduce new UCLASS_PCI_EP class for handling PCI endpoint
> devices, allowing to set various attributes of the PCI endpoint
> device, such as:
> * configuration space header
> * BAR definitions
> * outband memory mapping
> * start/stop PCI link
>
> Signed-off-by: Ramon Fried <ramon.fried at gmail.com>
>
> ---
> Changes in V2:
> - Changed u8/u16... to uint
> - Changed EINVAL to ENOSYS
> - Changed void funcs to int
> - Added a bit more info in comments
The only thing I see here is that unmap_addr should return an int, and
encode_int should be uint, not u8.
>
> drivers/Kconfig | 2 +
> drivers/Makefile | 1 +
> drivers/pci_endpoint/Kconfig | 17 ++
> drivers/pci_endpoint/Makefile | 6 +
> drivers/pci_endpoint/pci_ep-uclass.c | 189 +++++++++++++
> include/dm/uclass-id.h | 1 +
> include/pci_ep.h | 388 +++++++++++++++++++++++++++
> 7 files changed, 604 insertions(+)
> create mode 100644 drivers/pci_endpoint/Kconfig
> create mode 100644 drivers/pci_endpoint/Makefile
> create mode 100644 drivers/pci_endpoint/pci_ep-uclass.c
> create mode 100644 include/pci_ep.h
>
Regards,
Simon
More information about the U-Boot
mailing list