[U-Boot] [PATCH v2 02/11] lib: charset: add u16_strncmp()

[AKASHI Takahiro]

On Wed, Apr 24, 2019 at 08:36:09PM +0200, Heinrich Schuchardt wrote:
> On 4/24/19 8:30 AM, AKASHI Takahiro wrote:
> >u16_strncmp() works like u16_strcmp() but only at most n characters
> >(in u16) are compared.
> >This function will be used in a later patch.
> >
> >Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
> 
> The only usage of u16_strncmp() is in patch 3.
> u16_strcmp() is not used at all.

The fact is that u16_strcmp() is already used in my 'secure boot' patch
and then I moved on to non-volatile patch.

> In patch 3 'memcmp(var_name16, L"BOOT", 8)' will do the job.
> 
> I am not sure if in other cases we wouldn't prefer to compare Unicode
> codepoints instead of u16.

That is my concern, too :)

> So I suggest to skip patches 1 and 2 and use memcmp() in patch 3.

Okay, patch#1 will be planned to be included in 'secure boot' patch.

-Takahiro Akashi


> Best regards
> 
> Heinrich