[U-Boot] [PATCH V2 2/5] pico-imx7d: defconfig: Add DT file hooks

[Stefano Babic]

On 25/04/19 11:18, Joris OFFOUGA wrote:
> 
> 
> Le jeu. 25 avr. 2019 à 11:12, Stefano Babic <sbabic at denx.de
> <mailto:sbabic at denx.de>> a écrit :
> 
>     On 25/04/19 11:00, Stefano Babic wrote:
>     > On 04/04/19 14:00, Joris Offouga wrote:
>     >> This patch adds DT file hooks for Pico i.MX7D SOM and variant boards
>     >>
>     >> Signed-off-by: Joris Offouga <offougajoris at gmail.com
>     <mailto:offougajoris at gmail.com>>
>     >> ---
>     >>  configs/pico-hobbit-imx7d_defconfig | 3 ++-
>     >>  configs/pico-imx7d_defconfig        | 3 ++-
>     >>  configs/pico-pi-imx7d_defconfig     | 3 ++-
>     >>  3 files changed, 6 insertions(+), 3 deletions(-)
>     >>
>     >> diff --git a/configs/pico-hobbit-imx7d_defconfig
>     b/configs/pico-hobbit-imx7d_defconfig
>     >> index f58d517..75eab28 100644
>     >> --- a/configs/pico-hobbit-imx7d_defconfig
>     >> +++ b/configs/pico-hobbit-imx7d_defconfig
>     >> @@ -16,6 +16,8 @@ CONFIG_NR_DRAM_BANKS=1
>     >>  CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg"
>     >>  CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run distro_bootcmd"
>     >>  CONFIG_DEFAULT_FDT_FILE="imx7d-pico-hobbit.dtb"
>     >> +CONFIG_OF_CONTROL=y
>     >> +CONFIG_DEFAULT_DEVICE_TREE="imx7d-pico-hoobit"
>     >                                           ^---  two much "o"
>     >
>     > I fix this myself by merging.
>     >
>     >
> 
>     However, this fix pico-hobbit-imx7d, but not pico-imx7d. In fact, there
>     is no pico-imx7d.dts, but CONFIG_DEFAULT_DEVICE_TREE is set. Am I
>     missing something ?
> 
> No it's just som he does not need to CONFIG_DEFAULT_DEVICE_TREE
> Best regards,

I suppose this, but then something in the build is broken, If I run
buildman, a pico-imx7d board is searched. In fact, there is a
configs/pico-imx7d_defconfig. If this is just SOM, this file has no
reason to exist.

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================