[U-Boot] [PATCH] phycore-pcl060: U-boot support for Phytec phyCORE PCL060

[Marek Vasut]

On 4/25/19 10:31 AM, Niel Fourie wrote:
> Hi All,

Hi,

> On 4/19/19 11:47 AM, Marek Vasut wrote:
>>> ---
>>>   arch/arm/dts/Makefile                    |   3 +-
>>>   arch/arm/dts/am335x-phycore-som.dtsi     | 327 ++++++++++++++++++++++
>>>   arch/arm/dts/am335x-wega-rdk-u-boot.dtsi |  35 +++
>>>   arch/arm/dts/am335x-wega-rdk.dts         |  23 ++
>>>   arch/arm/dts/am335x-wega.dtsi            | 231 +++++++++++++++
>>
>> The DTs come from Linux kernel, but which version of Linux ?
>> Which exact commit ? Did you modify them in any way ?
> 
> I pulled these in from current Linux Mainline. I added SPDX headers and
> reformatted some lines to for line length (but I have reverted the line
> lengths in my follow-up patch).

The commit message should contain the commit ID in Linux from which the
files came , since when someone decides to upgrade those files in the
future, they will be able to generate a diff from that commit to Linux
version that's current at that point. Please add it.

>> [...]
>>
>>
>> Here [1] it says the name of the SoM is PCM-060 , what is PCL-060 ?
>>
>> [1]
>> https://www.phytec.eu/product-eu/system-on-modules/phycore-am335x-download/
>>
>>   [...]
>>
> 
> I renamed everything to variants of phycore_am335x_r2 as previously
> discussed.
> 
>> DRAM size should come from DT, we don't need another custom config
>> option. Look at fdtdec_setup_mem_size_base() and
>> fdtdec_setup_memory_banksize().
>>
> 
> Done, thank you for the suggestion. I also took inspiration for the data
> structure as suggested by Wadim Egorov.
> 
>>
>>> diff --git a/include/configs/phycore_pcl060.h
>>> b/include/configs/phycore_pcl060.h
>>> new file mode 100644
>>> index 0000000000..982c96b267
>>> --- /dev/null
>>> +++ b/include/configs/phycore_pcl060.h
>>> @@ -0,0 +1,141 @@
> 
> [...]
> 
>>> +/*
>>> + * USB configuration
>>> + */
>>> +#define CONFIG_AM335X_USB0
>>> +#define CONFIG_AM335X_USB0_MODE    MUSB_PERIPHERAL
>>> +#define CONFIG_AM335X_USB1
>>> +#define CONFIG_AM335X_USB1_MODE MUSB_HOST
>>
>> Can't the USB settings be extracted from DT ?
> 
> Unfortunately, these defines are referenced within
> arch/arm/mach-omap2/am335x/board.c, which I would rather not want to
> break at this time.

Take a look at
configs/am335x_evm_defconfig:CONFIG_DM_USB_GADGET=y

Maybe we can at least get rid of some of the hard-coded USB non-DM stuff.

-- 
Best regards,
Marek Vasut