[U-Boot] [PATCH] spi: Zap lpc32xx_ssp driver-related code

Jagan Teki jagan at amarulasolutions.com
Thu Apr 25 18:20:42 UTC 2019


On Thu, Apr 25, 2019 at 11:47 PM Tom Rini <trini at konsulko.com> wrote:
>
> On Thu, Apr 25, 2019 at 11:43:44PM +0530, Jagan Teki wrote:
> > On Wed, Apr 24, 2019 at 5:18 PM Tom Rini <trini at konsulko.com> wrote:
> > >
> > > On Wed, Apr 24, 2019 at 12:14:07PM +0530, Jagan Teki wrote:
> > > > On Tue, Apr 23, 2019 at 2:20 AM Vladimir Zapolskiy <vz at mleia.com> wrote:
> > > > >
> > > > > Hi Jagan, Tom,
> > > > >
> > > > > On 04/19/2019 09:48 AM, Jagan Teki wrote:
> > > > > > Dropped
> > > > > > - lpc32xx_ssp driver
> > > > > > - CONFIG_LPC32XX_SSP, LPC32XX_SSP_TIMEOUT items
> > > > > >
> > > > > > Dropped due to:
> > > > > > - no active updates
> > > > > > - no dm conversion
> > > > > > - multiple pings for asking dm-conversion
> > > > >
> > > > > I really don't want to rush into moaning, however let me ask you to drop
> > > > > the reason given above as invalid, otherwise please clarify who were
> > > > > the addressees of these 'multiple pings'.
> > > >
> > > > Here is the number iterations around the ML, this indeed a
> > > > notification for dm-conversion.
> > > > [1] [2][4][5]
> > > >
> > > > >
> > > > > > - no response for dm converted patch
> > > > >
> > > > > I believe there was no DM conversion patch for this particular driver,
> > > > > could it happen that I've missed it?
> > > >
> > > > [3]
> > > >
> > > > [1] https://patchwork.ozlabs.org/patch/1002858/
> > > > [2] https://patchwork.ozlabs.org/patch/1000463/
> > > > [3] https://patchwork.ozlabs.org/patch/910751/
> > > > [4] https://gitlab.incom.co/CM-Shield/u-boot/commit/c4e68d3aa8178f6aa63a79c4f8f459c0e3ed58e8?view=parallel
> > > > [5] https://lists.denx.de/pipermail/u-boot/2018-March/322135.html
> > >
> > > And to be clear and repeat myself, in all of the above cases while it
> > > did go to the ML it did not to/cc nearly enough (or in some cases I seem
> > > to recall, any) people directly responsible for the platforms in
> > > question.  I should have caught that and spoken up more at the time,
> > > sorry.
> >
> > Yes, with few driver patches but I mange to add individual board
> > vendor who effected that driver, but indeed it's very critical job to
> > include all since many drivers has lot of care takers. and I wouldn't
> > agree this point is the fact that this kind of Zap patch is 4 or 5th
> > version not the first time that people would have surprised.
>
> The problem is that Vladimir is one of the people that should have seen
> any of the previous instances, but didn't, and I'm sure this isn't the
> only instance.  So removal of unconverted drivers needs to be slow.

Okay, here is my next plan. will move all these zap driver configs to
BROKEN and give a warning during build that it would remove in next
version if dm conversion not done. my idea is to make build failure
with broken configs enablement, but that indeed trigger travis
failure.


More information about the U-Boot mailing list