[U-Boot] [PATCH 1/4 v5] watchdog: Implement generic watchdog_reset() version

Stefan Roese sr at denx.de
Fri Apr 26 10:47:50 UTC 2019


On 25.04.19 09:17, Stefan Roese wrote:
> This patch tries to implement a generic watchdog_reset() function that
> can be used by all boards that want to service the watchdog device in
> U-Boot. This watchdog servicing is enabled via CONFIG_WATCHDOG.
> 
> Without this approach, new boards or platforms needed to implement a
> board specific version of this functionality, mostly copy'ing the same
> code over and over again into their board or platforms code base.
> 
> With this new generic function, the scattered other functions are now
> removed to be replaced by the generic one. The new version also enables
> the configuration of the watchdog timeout via the DT "timeout-sec"
> property (if enabled via CONFIG_OF_CONTROL).
> 
> This patch also adds a new flag to the GD flags, to flag that the
> watchdog is ready to use and adds the pointer to the watchdog device
> to the GD. This enables us to remove the global "watchdog_dev"
> variable, which was prone to cause problems because of its potentially
> very early use in watchdog_reset(), even before the BSS is cleared.
> 
> Signed-off-by: Stefan Roese <sr at denx.de>
> Cc: Heiko Schocher <hs at denx.de>
> Cc: Tom Rini <trini at konsulko.com>
> Cc: Michal Simek <michal.simek at xilinx.com>
> Cc: "Marek Behún" <marek.behun at nic.cz>
> Cc: Daniel Schwierzeck <daniel.schwierzeck at gmail.com>
> Cc: Maxim Sloyko <maxims at google.com>
> Cc: Erik van Luijk <evanluijk at interact.nl>
> Cc: Ryder Lee <ryder.lee at mediatek.com>
> Cc: Weijie Gao <weijie.gao at mediatek.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: "Álvaro Fernández Rojas" <noltari at gmail.com>
> Cc: Philippe Reynes <philippe.reynes at softathome.com>
> Cc: Christophe Leroy <christophe.leroy at c-s.fr>
> Cc: Chris Packham <chris.packham at alliedtelesis.co.nz>
> Reviewed-by: Michal Simek <michal.simek at xilinx.com>
> Tested-by: Michal Simek <michal.simek at xilinx.com> (on zcu100)

Applied to u-boot-marvell/master.

Thanks,
Stefan


More information about the U-Boot mailing list