[U-Boot] [PATCH 1/5] pinctrl: gpio: Add callback for configuring pin as GPIO

Eugeniu Rosca roscaeugeniu at gmail.com
Fri Apr 26 12:16:30 UTC 2019


On Mon, Apr 22, 2019 at 12:20 AM Marek Vasut <marek.vasut at gmail.com> wrote:

[..]
> + * @gpio_request_enable: requests and enables GPIO on a certain pin.

nit: the existing documentation follows an imperative mood

[..]
> +        * gpio_request_enable: requests and enables GPIO on a certain pin.
[..]
> +        * gpio_disable_free: free up GPIO muxing on a certain pin.

nit: the established pattern is: 'name() - description', while here I
see 'name: description.'

Other than that:
Reviewed-by: Eugeniu Rosca <erosca at de.adit-jv.com>
Tested-by: Eugeniu Rosca <erosca at de.adit-jv.com>

Thanks!


More information about the U-Boot mailing list